Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 674773003: Oilpan: move TextFinder to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/TextFinder.cpp ('K') | « Source/web/WebLocalFrameImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index 2abeb0c510ca064da97fdbc9bf836a31ed26c4b4..d6842ae647fc39e6479030ac9e128cd0cdb208d3 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -1537,13 +1537,16 @@ WebLocalFrameImpl::~WebLocalFrameImpl()
Platform::current()->decrementStatsCounter(webFrameActiveCount);
frameCount--;
+#if !ENABLE(OILPAN)
cancelPendingScopingEffort();
haraken 2014/10/24 01:18:21 Just to confirm: It is ok not to call cancelPendin
sof 2014/10/24 05:32:00 Correct - the TextFinder is owned&controlled by We
+#endif
}
#if ENABLE(OILPAN)
void WebLocalFrameImpl::trace(Visitor* visitor)
{
visitor->trace(m_frame);
+ visitor->trace(m_textFinder);
visitor->trace(m_printContext);
visitor->trace(m_geolocationClientProxy);
visitor->registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(this);
« Source/web/TextFinder.cpp ('K') | « Source/web/WebLocalFrameImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698