ui/views/controls/menu/menu_separator_win.cc - Issue 674763002: remove ui::gfx::GetDeviceScaleFactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_separator_win.cc

Issue 674763002: remove ui::gfx::GetDeviceScaleFactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dpi-cleanup-3

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_separator_win.cc

diff --git a/ui/views/controls/menu/menu_separator_win.cc b/ui/views/controls/menu/menu_separator_win.cc

index 98a70baa6711c8573d18b8e5df5daaab45d50602..f6749682ce21ca2c4a5d2f382bd71fac53b23961 100644

--- a/ui/views/controls/menu/menu_separator_win.cc

+++ b/ui/views/controls/menu/menu_separator_win.cc

@@ -46,7 +46,7 @@ void MenuSeparator::OnPaint(gfx::Canvas* canvas) {

// Hack to get the separator to display correctly on Windows where we may

// have fractional scales. We move the separator 1 pixel down to ensure that

// it falls within the clipping rect which is scaled up.

- float device_scale = gfx::win::GetDeviceScaleFactor();

+ float device_scale = gfx::GetDPIScale();

bool is_fractional_scale =

(device_scale - static_cast<int>(device_scale) != 0);

if (is_fractional_scale && separator_bounds.y() == 0)