remove ui::gfx::GetDeviceScaleFactor

remove ui::gfx::GetDeviceScaleFactor

GetDPIScale() handles overrides, having two accessors is extra confusion.

R=sky@chromium.org
BUG=143619
Committed: https://crrev.com/67a57736b1cd516ff05116a5c27c4c5237f151fd
Cr-Commit-Position: refs/heads/master@{#300931}

[sky, 2014-10-23 16:51:51]

LGTM

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.cc
File ui/gfx/win/dpi.cc (right):

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.cc#newcode35
ui/gfx/win/dpi.cc:35: float GetUnforcedDeviceScaleFactor() {
Can you reanme devicescalefactor to dpiscale everywhere? If you want to do in a
separate patch, that's fine by me.

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
File ui/gfx/win/dpi.h (right):

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
Can this be named to SetDPIScale?

[scottmg, 2014-10-23 17:25:58]

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
File ui/gfx/win/dpi.h (right):

https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
On 2014/10/23 16:51:51, sky wrote:
> Can this be named to SetDPIScale?

I agree we should make them the same. The ui/compositor code uses
DeviceScaleFactor and device_scale_factor extensively, so maybe we should change
GetDPIScale instead?

[sky, 2014-10-23 17:28:47]

Go for it. I want constituency. If that means devicescalefactor so be it.

On Thu, Oct 23, 2014 at 10:25 AM,  <scottmg@chromium.org> wrote:
>
> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
> File ui/gfx/win/dpi.h (right):
>
> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
> ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
> On 2014/10/23 16:51:51, sky wrote:
>>
>> Can this be named to SetDPIScale?
>
>
> I agree we should make them the same. The ui/compositor code uses
> DeviceScaleFactor and device_scale_factor extensively, so maybe we
> should change GetDPIScale instead?
>
> https://codereview.chromium.org/674763002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-10-23 17:28:54]

Or rather consistency;)

On Thu, Oct 23, 2014 at 10:28 AM, Scott Violet <sky@chromium.org> wrote:
> Go for it. I want constituency. If that means devicescalefactor so be it.
>
> On Thu, Oct 23, 2014 at 10:25 AM,  <scottmg@chromium.org> wrote:
>>
>> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
>> File ui/gfx/win/dpi.h (right):
>>
>> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
>> ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
>> On 2014/10/23 16:51:51, sky wrote:
>>>
>>> Can this be named to SetDPIScale?
>>
>>
>> I agree we should make them the same. The ui/compositor code uses
>> DeviceScaleFactor and device_scale_factor extensively, so maybe we
>> should change GetDPIScale instead?
>>
>> https://codereview.chromium.org/674763002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-10-23 17:36:27]

You have my vote!

On Thu, Oct 23, 2014 at 10:28 AM, Scott Violet <sky@chromium.org> wrote:

> Or rather consistency;)
>
> On Thu, Oct 23, 2014 at 10:28 AM, Scott Violet <sky@chromium.org> wrote:
> > Go for it. I want constituency. If that means devicescalefactor so be it.
> >
> > On Thu, Oct 23, 2014 at 10:25 AM,  <scottmg@chromium.org> wrote:
> >>
> >> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
> >> File ui/gfx/win/dpi.h (right):
> >>
> >>
> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
> >> ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
> >> On 2014/10/23 16:51:51, sky wrote:
> >>>
> >>> Can this be named to SetDPIScale?
> >>
> >>
> >> I agree we should make them the same. The ui/compositor code uses
> >> DeviceScaleFactor and device_scale_factor extensively, so maybe we
> >> should change GetDPIScale instead?
> >>
> >> https://codereview.chromium.org/674763002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-10-23 17:37:10]

OK, I'll do that in a follow up that makes them all the same.

On Thu, Oct 23, 2014 at 10:28 AM, Scott Violet <sky@chromium.org> wrote:

> Go for it. I want constituency. If that means devicescalefactor so be it.
>
> On Thu, Oct 23, 2014 at 10:25 AM,  <scottmg@chromium.org> wrote:
> >
> > https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h
> > File ui/gfx/win/dpi.h (right):
> >
> >
> https://codereview.chromium.org/674763002/diff/1/ui/gfx/win/dpi.h#newcode20
> > ui/gfx/win/dpi.h:20: GFX_EXPORT void InitDeviceScaleFactor(float scale);
> > On 2014/10/23 16:51:51, sky wrote:
> >>
> >> Can this be named to SetDPIScale?
> >
> >
> > I agree we should make them the same. The ui/compositor code uses
> > DeviceScaleFactor and device_scale_factor extensively, so maybe we
> > should change GetDPIScale instead?
> >
> > https://codereview.chromium.org/674763002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-10-23 18:59:36]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-10-23 19:00:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674763002/20001

[commit-bot: I haz the power, 2014-10-23 19:48:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-23 19:49:02]

Patchset 2 (id:??) landed as
https://crrev.com/67a57736b1cd516ff05116a5c27c4c5237f151fd
Cr-Commit-Position: refs/heads/master@{#300931}