Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67473013: Support KitKat accessibility APIs. (Closed)

Created:
7 years, 1 month ago by dmazzoni
Modified:
7 years ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support KitKat accessibility APIs. The KitKat API adds a lot more accessibility data that can be exposed from Android applications. This implements all of them and updates test expectations. In addition, it exposes the same properties on JellyBean via a Bundle, allowing accessibility services a way to access this information even without KitKat, just without the clean API. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239114

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Don't log range type #

Patch Set 4 : Rebaseline expectations #

Total comments: 1

Patch Set 5 : Rebase, add prefix #

Total comments: 2

Patch Set 6 : Fix nit #

Patch Set 7 : Rebase #

Patch Set 8 : Fix merge error #

Patch Set 9 : int -> long for native pointers #

Patch Set 10 : Add dummy Mac and Win expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -65 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_android.cc View 1 2 3 4 5 6 4 chunks +45 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 1 2 3 4 5 6 3 chunks +28 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 3 4 5 6 7 8 9 7 chunks +202 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 2 3 4 2 chunks +68 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 2 3 4 5 4 chunks +93 lines, -1 line 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java View 1 2 3 4 5 6 7 8 1 chunk +97 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-combobox-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-level-expected-android.txt View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M content/test/data/accessibility/aria-progressbar-expected-android.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-valuemax-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-valuemin-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/contenteditable-descendants-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/dl-expected-android.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/heading-expected-android.txt View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
M content/test/data/accessibility/input-range-expected-android.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/input-types.html View 1 chunk +28 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-types-expected-android.txt View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-types-expected-mac.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/input-types-expected-win.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/list-markers-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/spinbutton-expected-android.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/table-simple-expected-android.txt View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/ul-expected-android.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dmazzoni
7 years, 1 month ago (2013-11-18 07:20:41 UTC) #1
Peter Lundblad
https://codereview.chromium.org/67473013/diff/120001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java File content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java (right): https://codereview.chromium.org/67473013/diff/120001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java#newcode497 content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:497: bundle.putBoolean("canOpenPopup", canOpenPopup); Since we are not doing any namespacing ...
7 years, 1 month ago (2013-11-19 18:40:53 UTC) #2
dmazzoni
On 2013/11/19 18:40:53, Peter Lundblad wrote: > https://codereview.chromium.org/67473013/diff/120001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java > File > content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java > (right): > ...
7 years, 1 month ago (2013-11-20 07:29:28 UTC) #3
dmazzoni
Added prefix to all items added to the bundle, as requested.
7 years ago (2013-12-02 16:49:40 UTC) #4
Peter Lundblad
lgtm
7 years ago (2013-12-03 16:01:36 UTC) #5
dmazzoni
+yfriedman for OWNERS review of content/public/android
7 years ago (2013-12-03 16:36:03 UTC) #6
Yaron
+dtrainor who's a better reviewer for this
7 years ago (2013-12-03 17:47:27 UTC) #7
David Trainor- moved to gerrit
lgtm but you'll still need Yaron's owner lgtm. https://codereview.chromium.org/67473013/diff/300001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java File content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java (right): https://codereview.chromium.org/67473013/diff/300001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java#newcode247 content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:247: Bundle ...
7 years ago (2013-12-03 21:55:34 UTC) #8
Yaron
On 2013/12/03 21:55:34, David Trainor wrote: > lgtm but you'll still need Yaron's owner lgtm. ...
7 years ago (2013-12-03 23:02:08 UTC) #9
dmazzoni
https://codereview.chromium.org/67473013/diff/300001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java File content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java (right): https://codereview.chromium.org/67473013/diff/300001/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java#newcode247 content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:247: Bundle bundle = (Bundle)event.getParcelableData(); On 2013/12/03 21:55:35, David Trainor ...
7 years ago (2013-12-04 00:37:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/67473013/380001
7 years ago (2013-12-04 08:12:34 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=196878
7 years ago (2013-12-04 09:19:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/67473013/400001
7 years ago (2013-12-05 20:09:06 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-06 04:11:55 UTC) #14
Message was sent while issue was closed. 
Change committed as 239114

Powered by Google App Engine
This is Rietveld 408576698