Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest.cc

Issue 67473008: PDFBrowserTest.Basic (see http://crbug.com/152330), PDFBrowserTest.FindAndCopy and PDFBrowserTest.S… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/pdf/pdf_browsertest.cc
diff --git a/chrome/browser/ui/pdf/pdf_browsertest.cc b/chrome/browser/ui/pdf/pdf_browsertest.cc
index b464e70d676147e8fe38020a8ad67197e459eb59..cf575c346ed19bbc344bf9b8ed6813bf92c9d1a2 100644
--- a/chrome/browser/ui/pdf/pdf_browsertest.cc
+++ b/chrome/browser/ui/pdf/pdf_browsertest.cc
@@ -210,7 +210,8 @@ class PDFBrowserTest : public InProcessBrowserTest,
net::test_server::EmbeddedTestServer pdf_test_server_;
};
-#if defined(OS_CHROMEOS)
+// Failing on official Windows bot. http://crbug.com/152330
+#if defined(OS_CHROMEOS) || (defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN))
// TODO(sanjeevr): http://crbug.com/79837
#define MAYBE_Basic DISABLED_Basic
#else
@@ -234,7 +235,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Basic) {
#endif
}
-#if defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS) || (defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN))
// TODO(sanjeevr): http://crbug.com/79837
#define MAYBE_Scroll DISABLED_Scroll
#else
@@ -264,7 +265,7 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Scroll) {
ASSERT_GT(y_offset, 0);
}
-#if defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS) || (defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN))
// TODO(sanjeevr): http://crbug.com/79837
#define MAYBE_FindAndCopy DISABLED_FindAndCopy
#else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698