Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 67473008: PDFBrowserTest.Basic (see http://crbug.com/152330), PDFBrowserTest.FindAndCopy and PDFBrowserTest.S… (Closed)

Created:
7 years, 1 month ago by pshenoy
Modified:
7 years, 1 month ago
CC:
chromium-reviews, anantha, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

PDFBrowserTest.Basic (see http://crbug.com/152330), PDFBrowserTest.FindAndCopy and PDFBrowserTest.Scroll (see http://crbug.com/79837) are failing consistently on official Windows bot. Disabling it for now to keep official bot green. BUG=152330, 79837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/pdf/pdf_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pshenoy
7 years, 1 month ago (2013-11-15 19:00:20 UTC) #1
Lei Zhang
lgtm
7 years, 1 month ago (2013-11-15 20:35:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/67473008/1
7 years, 1 month ago (2013-11-15 20:53:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/67473008/1
7 years, 1 month ago (2013-11-15 22:05:14 UTC) #4
jam
this is very strange, they do pass locally for me could it be for some ...
7 years, 1 month ago (2013-11-15 22:38:32 UTC) #5
jam
Lei: do you have the bandwidth to look into this?
7 years, 1 month ago (2013-11-15 22:38:46 UTC) #6
Lei Zhang
On 2013/11/15 22:38:46, jam wrote: > Lei: do you have the bandwidth to look into ...
7 years, 1 month ago (2013-11-15 22:40:44 UTC) #7
jam
On 2013/11/15 22:40:44, Lei Zhang wrote: > On 2013/11/15 22:38:46, jam wrote: > > Lei: ...
7 years, 1 month ago (2013-11-15 22:59:27 UTC) #8
pshenoy
+ Pawel Here is the link to the failing builder. http://master.chrome.corp.google.com:8011/builders/win%20trunk/builds/12936 I spoke to Pawel ...
7 years, 1 month ago (2013-11-15 23:19:22 UTC) #9
pshenoy
Logged a bug http://crbug.com/320093 and assigned it to Pawel.
7 years, 1 month ago (2013-11-15 23:26:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/67473008/1
7 years, 1 month ago (2013-11-18 18:34:34 UTC) #11
commit-bot: I haz the power
Change committed as 235802
7 years, 1 month ago (2013-11-18 20:09:00 UTC) #12
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-19 22:52:39 UTC) #13
Message was sent while issue was closed.
I don't think disabling these tests on GOOGLE_CHROME_BUILD is the right thing to
do.

I recommend reverting this patch.

Powered by Google App Engine
This is Rietveld 408576698