Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 67473007: Fix missing type feedback check for Generic*String addition. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix missing type feedback check for Generic*String addition. TEST=mjsunit/regress/regress-crbug-318671 BUG=318671 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M src/hydrogen.cc View 2 chunks +19 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-318671.js View 1 chunk +7 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 1 month ago (2013-11-15 08:58:19 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-11-15 09:12:44 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-11-15 09:13:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698