ui/gfx/render_text_unittest.cc - Issue 674683003: Avoid extra FontRenderParams queries in RenderTextHarfBuzz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 674683003: Avoid extra FontRenderParams queries in RenderTextHarfBuzz. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: restore check that a family was actually found Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_unittest.cc

diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc

index 10a0a90b45ddd98269d27f387df9856bc368acfa..1c6f902d936fb435827912df67561e1d1af51c51 100644

--- a/ui/gfx/render_text_unittest.cc

+++ b/ui/gfx/render_text_unittest.cc

@@ -15,6 +15,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/gfx/break_list.h"

#include "ui/gfx/canvas.h"

+#include "ui/gfx/font.h"

#include "ui/gfx/render_text_harfbuzz.h"

#if defined(OS_WIN)

@@ -2287,7 +2288,8 @@ TEST_F(RenderTextTest, HarfBuzz_NonExistentFont) {

render_text.EnsureLayout();

ASSERT_EQ(1U, render_text.runs_.size());

internal::TextRunHarfBuzz* run = render_text.runs_[0];

- render_text.ShapeRunWithFont(run, "TheFontThatDoesntExist");

+ render_text.ShapeRunWithFont(

+ run, "TheFontThatDoesntExist", FontRenderParams());

}

// Ensure an empty run returns sane values to queries.

« no previous file with comments | « ui/gfx/render_text_harfbuzz.cc ('k') | no next file » | no next file with comments »