IndexedDB: Simplify WebIDBCallbacks exports, strip IDBFactoryBackend

IndexedDB: Simplify WebIDBCallbacks exports, strip IDBFactoryBackend

Eliminate the blink impl of WebIDBCallbacks - implement it in
WebCore (Source/modules). Simultaneously, strip IDBFactoryBackendProxy
down to the bare essentials - an allowIndexedDB() call. (That API
could be moved to Platform or some such in a follow-on patch.)

BUG=234277
R=alecflett@chromium.org,adamk@chromium.org,jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162738

[alecflett, 2013-11-22 18:19:04]

yay! lgtm

https://codereview.chromium.org/67463006/diff/1/Source/modules/indexeddb/IDBC...
File Source/modules/indexeddb/IDBCursor.cpp (right):

https://codereview.chromium.org/67463006/diff/1/Source/modules/indexeddb/IDBC...
Source/modules/indexeddb/IDBCursor.cpp:233: m_backend->continueFunction(key,
WebIDBCallbacksImpl::create(m_request).leakPtr());
ah now I see what you mean in the other patch about leakPtr :)

[jsbell, 2013-11-25 19:19:12]

adamk@ - can you review the Source/web simplification? (This leaves
IDBFactoryBackendXXX as a poorly named permission stub)

abarth@ - OWNERS review of public/platform? (Note that this basically restores
WebIDBCallbacks.h to what it looked like prior to r161569 when I took it on a
bit of a goose chase.)

[abarth-chromium, 2013-11-25 21:29:50]

public/platform <--- LGTM

[adamk, 2013-11-25 21:56:44]

lgtm, and an optional slight simplification of allowIndexedDB() suggested

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
File Source/web/IDBFactoryBackendProxy.cpp (right):

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:54: bool allowed;
You could get rid of this bool now that you check it in the caller instead...

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:62: allowed = !webView->permissionClient()
|| webView->permissionClient()->allowIndexedDB(webFrame, name, origin);
..and then return this directly...

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:63: } else {
...get rid of the else...

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:65: allowed =
WorkerPermissionClient::from(workerGlobalScope)->allowIndexedDB(name);
and return this too.

[jsbell, 2013-11-26 00:42:52]

Simplified allowIndexedDB as suggested.

Also removed the m_upgradeNeededCalled member of WebIDBCallbacksImpl, although
this turns out to be dependent on http://crrev.com/86773002

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
File Source/web/IDBFactoryBackendProxy.cpp (right):

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:54: bool allowed;
On 2013/11/25 21:56:44, adamk wrote:
> You could get rid of this bool now that you check it in the caller instead...

Done.

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:62: allowed = !webView->permissionClient()
|| webView->permissionClient()->allowIndexedDB(webFrame, name, origin);
On 2013/11/25 21:56:44, adamk wrote:
> ..and then return this directly...

Done.

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:63: } else {
On 2013/11/25 21:56:44, adamk wrote:
> ...get rid of the else...

Done.

https://codereview.chromium.org/67463006/diff/50001/Source/web/IDBFactoryBack...
Source/web/IDBFactoryBackendProxy.cpp:65: allowed =
WorkerPermissionClient::from(workerGlobalScope)->allowIndexedDB(name);
On 2013/11/25 21:56:44, adamk wrote:
> and return this too.

Done.

[commit-bot: I haz the power, 2013-11-27 00:33:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/67463006/110001

[commit-bot: I haz the power, 2013-11-27 09:40:38]

Change committed as 162738