Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 674553002: Move parts of core/dom to C++11 (Closed)

Created:
6 years, 2 months ago by kenneth.r.christiansen
Modified:
6 years, 2 months ago
Reviewers:
Mike West, darktears
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Move parts of core/dom to C++11 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184261

Patch Set 1 #

Patch Set 2 : Fixed bug #

Patch Set 3 : Moar bug fixes #

Patch Set 4 : Make Windows shut up when I just try following the style guide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -251 lines) Patch
M Source/core/dom/AttributeCollection.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 3 25 chunks +59 lines, -59 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 3 chunks +17 lines, -17 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M Source/core/dom/Node.h View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 33 chunks +81 lines, -88 lines 0 comments Download
M Source/core/dom/PresentationAttributeStyle.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M Source/core/dom/Range.cpp View 12 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
darktears
On 2014/10/23 12:07:04, kenneth.r.christiansen wrote: > mailto:kenneth.r.christiansen@intel.com changed reviewers: > + mailto:mkwst@chromium.org rs=me
6 years, 2 months ago (2014-10-23 12:17:56 UTC) #2
darktears
On 2014/10/23 12:17:56, darktears wrote: > On 2014/10/23 12:07:04, kenneth.r.christiansen wrote: > > mailto:kenneth.r.christiansen@intel.com changed ...
6 years, 2 months ago (2014-10-23 12:18:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674553002/60001
6 years, 2 months ago (2014-10-23 12:19:42 UTC) #5
Mike West
LGTM 2, thanks.
6 years, 2 months ago (2014-10-23 12:20:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 12:24:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 184261

Powered by Google App Engine
This is Rietveld 408576698