src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp - Issue 674543004: OptState owns program descriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp

Issue 674543004: OptState owns program descriptor (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: cleaup Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp b/src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp

index 1c1cb421223b366747058be5cd3775d8cd9e0e67..c0c4fbb46ed17eb2426013590b30698da7a3d8e4 100644

--- a/src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp

+++ b/src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp

@@ -9,12 +9,9 @@

#include "../GrGpuGL.h"

GrGLLegacyNvprProgramBuilder::GrGLLegacyNvprProgramBuilder(GrGpuGL* gpu,

- const GrOptDrawState& optState,

- const GrGLProgramDesc& desc)

- : INHERITED(gpu, optState, desc)

+ const GrOptDrawState& optState)

+ : INHERITED(gpu, optState)

, fTexCoordSetCnt(0) {

- SkASSERT(GrGLProgramDesc::kAttribute_ColorInput != desc.getHeader().fColorInput);

- SkASSERT(GrGLProgramDesc::kAttribute_ColorInput != desc.getHeader().fCoverageInput);

}

int GrGLLegacyNvprProgramBuilder::addTexCoordSets(int count) {