src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp - Issue 674543004: OptState owns program descriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp

Issue 674543004: OptState owns program descriptor (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: feedback inc Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp b/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp

index 76026b7a25005509701e91a874837d72555fe81f..21df3629ed11da62f12db1e843881a8cba6d623e 100644

--- a/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp

+++ b/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp

@@ -98,7 +98,7 @@ void GrGLVertexBuilder::transformSkiaToGLCoords() {

void GrGLVertexBuilder::bindVertexAttributes(GrGLuint programID) {

// Bind the attrib locations to same values for all shaders

- const GrGLProgramDesc::KeyHeader& header = fProgramBuilder->header();

+ const GrProgramDesc::KeyHeader& header = fProgramBuilder->header();

SkASSERT(-1 != header.fPositionAttributeIndex);

GL_CALL(BindAttribLocation(programID,

header.fPositionAttributeIndex,