LayoutTests/inspector/console/console-log-linkify-stack-in-errors.html - Issue 674513002: DevTools: linkify relative links in console.log(new Error().stack)

Side by Side Diff: LayoutTests/inspector/console/console-log-linkify-stack-in-errors.html

Issue 674513002: DevTools: linkify relative links in console.log(new Error().stack) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address aandrey comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt » ('j') | Source/devtools/front_end/console/ConsoleViewMessage.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/console-test.js"></script>

	5 <script>

	6

	7 function forStack()

	8 {

	9 console.log(new Error("line\nbreak").stack);

	10 }

	11

	12 forStack();

	13

	14 console.log("Error message without stacks http://www.chromium.org/");

	15

	16 console.log("Error valid stack #1\n at function_name(foo.js:30:1)\n at boo .js:40:70");

	17 console.log("Error valid stack #2\n at http://www.chromium.org/boo.js:40:70\n at foo(http://www.chromium.org/foo.js:10:50)");

	18 console.log("Error valid stack #3\n at http://www.chromium.org/foo.js:40");

	19 console.log("Error valid stack #4\n at function_name (some.js:30)");

	20 console.log("Error valid\n stack #5\n at function_name (some.js:30)");

	21 console.log("Error valid stack #6\n at function_name(foo.js:30:1)\n at boo .js:40:70\n at another_function(foo.js:50:500)");

	22 console.log("ReferenceError valid stack #1\n at function_name(foo.js:30:1)\n at boo.js:40:70");

	23 console.log("EvalError valid stack #1\n at function_name(foo.js:30:1)\n at boo.js:40:70");

	24 console.log("SyntaxError valid stack #1\n at function_name(foo.js:30:1)\n at boo.js:40:70");

	25 console.log("RangeError valid stack #1\n at function_name(foo.js:30:1)\n a t boo.js:40:70");

	26 console.log("TypeError valid stack #1\n at function_name(foo.js:30:1)\n at boo.js:40:70");

	27 console.log("URIError valid stack #1\n at function_name(foo.js:30:1)\n at boo.js:40:70");

	28

	29 console.log("Error broken stack\n at function_name(rooo.js foo.js:30:1)\n at boo.js:40:70");

	30 console.log("Error broken stack #2\n at function_name(some.js:20:30");

	31 console.log("Error broken stack #3\n at function_name(some:20.js:30 bla");

	32 console.log("Error broken stack #4\n at function_name)some.js:20:30(");

	33 console.log("Error broken stack #5\n at function_name some.js:20:30)");

	34 console.log("Error broken stack #6\n at foo.js boo.js:40:70");

	35

	36 console.log("Error: Failed to execute 'removeChild' on 'Node': The node to be re moved is not a child of this node.\nat Object.InjectedScript._evaluateOn (<anony mous>:732:137)\nat Object.InjectedScript._evaluateAndWrap (<anonymous>:665:34)\n at Object.InjectedScript.evaluate (<anonymous>:579:21)");

	37

	38 function test()
	vsevik 2014/10/27 09:04:55 I would expect to see new Error().stack calls from I would expect to see new Error().stack calls from scripts with sourceURL in this test. I think all cases where the error message represents a correct stack trace should be actually generated by v8. Also I don't see how these URLs could actually be linkified to scripts if you don't have this scripts at all. sergeyv 2014/10/30 14:38:39 Done. Show quoted text On 2014/10/27 09:04:55, vsevik wrote: > I would expect to see new Error().stack calls from scripts with sourceURL in > this test. > I think all cases where the error message represents a correct stack trace > should be actually generated by v8. > Also I don't see how these URLs could actually be linkified to scripts if you > don't have this scripts at all. Done.
	39 {

	40 InspectorTest.dumpConsoleMessages(false, true);

	41 InspectorTest.completeTest();

	42 }

	43 </script>

	44 </head>

	45 <body onload="runTest()">

	46 <p>

	47 Test that console.log(new Error().stack) would linkify all links even relative o nes. <a href="http://crbug.com/424001">Bug 424001.</a>

	48 </p>

	49 </body>

	50 </html>

OLD	NEW