DevTools: linkify relative links in console.log(new Error().stack)

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 148 matching lines @@
                     case WebInspector.ConsoleMessage.MessageType.Dir:
                         var obj = consoleMessage.parameters ? consoleMessage.parameters[0] : undefined;
                         var args = ["%O", obj];
                         this._messageElement = this._format(args);
                         break;
                     case WebInspector.ConsoleMessage.MessageType.Profile:
                     case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
                         this._messageElement = this._format([consoleMessage.messageText]);
                         break;
                     default:
+                        if (consoleMessage.parameters && consoleMessage.parameters.length === 1 && consoleMessage.parameters[0].type === "string")
+                             this._messageElement = this._tryFormatAsError(/**@type {string} */(consoleMessage.parameters[0].value));
+
                         var args = consoleMessage.parameters || [consoleMessage.messageText];
-                        this._messageElement = this._format(args);
+                        this._messageElement = this._messageElement || this._format(args);
                 }
             } else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
                 if (consoleMessage.request) {
                     this._messageElement = createElement("span");
                     if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error) {
                         this._messageElement.createTextChildren(consoleMessage.request.requestMethod, " ");
                         this._messageElement.appendChild(WebInspector.Linkifier.linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
                         if (consoleMessage.request.failed)
                             this._messageElement.createTextChildren(" ", consoleMessage.request.localizedFailDescription);
                         else
@@ skipping 1084 matching lines @@
                 break;
         }
 
         return sourceString + " " + typeString + " " + levelString + ": " + this.formattedMessage().textContent + "\n" + this._message.url + " line " + this._message.line;
     },
 
     get text()
     {
         return this._message.messageText;
     },
+
+    /**
+     * @param {string} string
+     * @return {?Element}
+     */
+    _tryFormatAsError: function(string)
+    {
+        if (!string.startsWith("Error"))

[aandrey, 2014/10/23 17:51:30]

what about ReferenceError? RangeError, SyntaxError, etc.
what about DOMException?

plz add such test cases.

1) return foo.ref.error;

2)
  Error: Failed to execute 'removeChild' on 'Node': The node to be removed is
not a child of this node.
    at Error (native)
    at <anonymous>:4:3
    at Object.InjectedScript._evaluateOn (<anonymous>:732:137)
    at Object.InjectedScript._evaluateAndWrap (<anonymous>:665:34)
    at Object.InjectedScript.evaluate (<anonymous>:579:21)

[sergeyv, 2014/10/27 08:30:59]

Done.

+            return null;
+
+        var lines = string.split("\n");
+        var links = [];
+        var position = 0;
+        var beforeStack = true;
+        for (var i = 0; i < lines.length; ++i) {
+            position += i > 0 ? lines[i - 1].length + 1 : 0;
+            var hasAt = lines[i].trim().startsWith("at ");

[aandrey, 2014/10/23 17:51:30]

var isCallFrameLine = /^\s*at\s/.test(lines[i]);

[sergeyv, 2014/10/27 08:30:59]

Done.

+            if (!hasAt && !beforeStack)

[aandrey, 2014/10/23 17:51:30]

beforeStack -> links.length

[sergeyv, 2014/10/27 08:31:00]

Done.

+                return null;
+
+            if (!hasAt)
+                continue;
+
+            beforeStack = false;
+
+            var openBracketIndex = lines[i].indexOf("(");
+            var closeBracketIndex = lines[i].indexOf(")");
+            var hasOpenBracket = openBracketIndex !== -1;
+            var hasCloseBracket = closeBracketIndex !== -1;
+
+            if ((openBracketIndex > closeBracketIndex) ||  (hasOpenBracket ^ hasCloseBracket))
+                return null;
+
+            var left = hasOpenBracket ? openBracketIndex + 1 : lines[i].indexOf("at") + 3;
+            var right = hasOpenBracket ? closeBracketIndex : lines[i].length;
+            var linkPretender = lines[i].substring(left, right);
+            var splitResult = WebInspector.ParsedURL.splitLineAndColumn(linkPretender);
+            if (!splitResult)
+                return null;
+
+            var parsed = splitResult.url.asParsedURL();
+            if (!parsed) {
+                var completeURL = WebInspector.ParsedURL.completeURL(WebInspector.targetManager.inspectedPageURL(), splitResult.url);
+                parsed = completeURL ? completeURL.asParsedURL() : null;
+            }
+
+            if (!parsed)
+                return null;
+
+            links.push({url: parsed.url, positionLeft: position + left, positionRight: position + right, lineNumber: splitResult.lineNumber, columnNumber: splitResult.columnNumber});

[aandrey, 2014/10/23 17:51:30]

too complex...

[sergeyv, 2014/10/27 08:31:00]

Acknowledged.

+        }
+
+        if (beforeStack)
+            return null;
+
+        var formattedResult = createElement("span");
+        var start = 0;
+        for (var i = 0; i < links.length; ++i) {
+            formattedResult.appendChild(this._linkifier.linkifyStringAsFragment(this._target(), string.substring(start, links[i].positionLeft)));
+            formattedResult.appendChild(this._linkifier.linkifyScriptLocation(this._target(), null, links[i].url, links[i].lineNumber, links[i].columnNumber));
+            start = links[i].positionRight;
+        }
+
+        if (start != string.length)
+            formattedResult.appendChild(this._linkifier.linkifyStringAsFragment(this._target(), string.substring(start)));
+
+        return formattedResult;
+    }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.ConsoleViewMessage}
  * @param {!WebInspector.ConsoleMessage} consoleMessage
  * @param {!WebInspector.Linkifier} linkifier
  * @param {number} nestingLevel
  */
 WebInspector.ConsoleGroupViewMessage = function(consoleMessage, linkifier, nestingLevel)
@@ skipping 29 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }