DevTools: linkify relative links in console.log(new Error().stack)

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 148 matching lines @@
                     case WebInspector.ConsoleMessage.MessageType.Dir:
                         var obj = consoleMessage.parameters ? consoleMessage.parameters[0] : undefined;
                         var args = ["%O", obj];
                         this._messageElement = this._format(args);
                         break;
                     case WebInspector.ConsoleMessage.MessageType.Profile:
                     case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
                         this._messageElement = this._format([consoleMessage.messageText]);
                         break;
                     default:
+                        if (consoleMessage.parameters && consoleMessage.parameters.length === 1 && consoleMessage.parameters[0].type === "string")
+                             this._messageElement = this._tryFormatAsError(/**@type {string} */(consoleMessage.parameters[0].value));
+
                         var args = consoleMessage.parameters || [consoleMessage.messageText];
-                        this._messageElement = this._format(args);
+                        this._messageElement = this._messageElement || this._format(args);
                 }
             } else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
                 if (consoleMessage.request) {
                     this._messageElement = createElement("span");
                     if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error) {
                         this._messageElement.createTextChildren(consoleMessage.request.requestMethod, " ");
                         this._messageElement.appendChild(WebInspector.Linkifier.linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
                         if (consoleMessage.request.failed)
                             this._messageElement.createTextChildren(" ", consoleMessage.request.localizedFailDescription);
                         else
@@ skipping 1076 matching lines @@
                 break;
         }
 
         return sourceString + " " + typeString + " " + levelString + ": " + this.formattedMessage().textContent + "\n" + this._message.url + " line " + this._message.line;
     },
 
     get text()
     {
         return this._message.messageText;
     },
+
+    /**
+     * @param {string} string
+     * @return {?Element}
+     */
+    _tryFormatAsError: function(string)
+    {
+        if (!string.startsWith("Error"))
+            return null;
+
+        var lines = string.split("\n");
+        var beforeAts = true;
+        //check format
+        for (var i = 0; i < lines.length; ++i) {

[vsevik, 2014/10/23 08:40:57]

var i = 0;
for (; i < lines.length && !lines[i].trim().startsWith("at"); ++i);
var firstAtLineIndex = i;
for (; i < lines.length && lines[i].trim().startsWith("at"); ++i);
if (i !== lines.length)
    return null;

+            var atLine = lines[i].trim().startsWith("at");
+            if (beforeAts && atLine) {
+                beforeAts = false;
+                continue;
+            }
+            if (!beforeAts && !atLine)
+                return null;
+        }
+
+        if (beforeAts)
+            return null;
+
+        var formattedResult = createElement("span");
+        for (var i = 0; i < lines.length; ++i) {

[vsevik, 2014/10/23 08:40:57]

for (var i = 0; i < firstAtLineIndex; ++i) {
  ....
}
for (var i = firstAtLineIndex; i < lines.length; ++i) {
  ....
}

+            var atLine = lines[i].trim().startsWith("at ");
+            if (!atLine)
+                formattedResult.appendChild(this._linkifier.linkifyStringAsFragment(this._target(), lines[i] + "\n"));
+            else {
+                var openBracket = lines[i].indexOf("(");
+                var closeBracket = lines[i].indexOf(")");
+                var left = openBracket === -1 ? lines[i].indexOf("at") + 3 : openBracket + 1;
+                var right = closeBracket === -1? lines[i].length : closeBracket;
+                formattedResult.appendChild(createTextNode(lines[i].substring(0, left)));
+                var toAppend = this._parseLink(lines[i].substring(left, right));

[vsevik, 2014/10/23 08:40:57]

We need to check that this line matches some very basic url filter, this is only
an heuristic after all.

+                formattedResult.appendChild(toAppend);
+                formattedResult.appendChild(createTextNode(lines[i].substring(right, lines[i].length) + "\n"))
+            }
+
+        }
+        return formattedResult;
+    },
+
+    /**
+     * @param {string} link
+     * @return {!Node}
+     */
+    _parseLink: function(link)
+    {
+        var splitResult = WebInspector.ParsedURL.splitLineAndColumn(link);
+        if (!splitResult) {

[vsevik, 2014/10/23 10:47:27]

extra {

+            return this._linkifier.linkifyStringAsFragment(this._target(), link);
+        }
+
+        var parsed = splitResult.url.asParsedURL();
+        if (!parsed)
+            parsed = new WebInspector.ParsedURL(WebInspector.targetManager.inspectedPageURL() +  splitResult.url);
+
+        return parsed.isValid ? this._linkifier.linkifyScriptLocation(this._target(), null, splitResult.url, splitResult.lineNumber, splitResult.columnNumber) : createTextNode(link);

[vsevik, 2014/10/23 10:47:27]

Shouldn't we use parsed here?

+    }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.ConsoleViewMessage}
  * @param {!WebInspector.ConsoleMessage} consoleMessage
  * @param {!WebInspector.Linkifier} linkifier
  * @param {number} nestingLevel
  */
 WebInspector.ConsoleGroupViewMessage = function(consoleMessage, linkifier, nestingLevel)
@@ skipping 29 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }