Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 674503002: Do not skip site import on python startup for v8 binding generation. (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove the -S option when invoking the bindings generator to allow implicit 'import site' by the python runtime. NOTRY=true BUG=425932 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/bindings/modules/v8/generated.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
elecro
The problem occured on one of the linux bots: FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; python -S ../../scripts/idl_compiler.py ...
6 years, 2 months ago (2014-10-22 13:06:49 UTC) #2
Jens Widell
LGTM
6 years, 2 months ago (2014-10-22 13:11:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674503002/1
6 years, 2 months ago (2014-10-22 13:13:59 UTC) #5
haraken
LGTM
6 years, 2 months ago (2014-10-22 13:32:13 UTC) #6
kochi
Just a question: why didn't it always fail then?
6 years, 2 months ago (2014-10-22 14:47:18 UTC) #8
Paweł Hajdan Jr.
On 2014/10/22 14:47:18, Takayoshi Kochi wrote: > Just a question: why didn't it always fail ...
6 years, 2 months ago (2014-10-22 14:52:03 UTC) #9
elecro
On 2014/10/22 14:47:18, Takayoshi Kochi wrote: > Just a question: why didn't it always fail ...
6 years, 2 months ago (2014-10-22 14:55:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33087)
6 years, 2 months ago (2014-10-22 15:20:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674503002/1
6 years, 2 months ago (2014-10-22 16:39:47 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 16:40:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184195

Powered by Google App Engine
This is Rietveld 408576698