Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 674453003: QUIC - Record loading of QUICServerInfo from disk cache. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, rvargas (doing something else)
Base URL:
https://chromium.googlesource.com/chromium/src.git@disk_cache_rtt_fix
Project:
chromium
Visibility:
Public.

Description

QUIC - Record loading of QUICServerInfo from disk cache. Added Net.QuicServerInfo.DiskCacheLoadTime histogram to track the read time. R=asvitkine@chromium.org, rch@chromium.org Committed: https://crrev.com/6ab66362b09827c5e93e574a2aa13519272812fe Cr-Commit-Position: refs/heads/master@{#300710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M net/http/disk_cache_based_quic_server_info.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
The following are the different times we are measuring. DiskCacheLoadTime will be less than HostResolutionTime ...
6 years, 2 months ago (2014-10-22 00:38:05 UTC) #2
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-22 02:56:01 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-10-22 15:08:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674453003/1
6 years, 2 months ago (2014-10-22 16:46:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 18:25:26 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:26:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab66362b09827c5e93e574a2aa13519272812fe
Cr-Commit-Position: refs/heads/master@{#300710}

Powered by Google App Engine
This is Rietveld 408576698