Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js

Issue 674443003: DevTools: ignore weak referenced when calculating dominators for heap snapshot (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
diff --git a/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js b/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
index 9d75df1f8cd1c79d61d9997b9c72b83b61c22736..1f2ab3bedeed25b0f8897818bd2f4901bdd0b276 100644
--- a/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
+++ b/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
@@ -1558,6 +1558,7 @@ WebInspector.HeapSnapshot.prototype = {
var edgeTypeOffset = this._edgeTypeOffset;
var edgeToNodeOffset = this._edgeToNodeOffset;
var edgeShortcutType = this._edgeShortcutType;
+ var edgeWeakType = this._edgeWeakType;
var firstEdgeIndexes = this._firstEdgeIndexes;
var containmentEdges = this.containmentEdges;
var containmentEdgesLength = this.containmentEdges.length;
@@ -1611,6 +1612,8 @@ WebInspector.HeapSnapshot.prototype = {
for (var retainerIndex = beginRetainerIndex; retainerIndex < endRetainerIndex; ++retainerIndex) {
var retainerEdgeIndex = retainingEdges[retainerIndex];
var retainerEdgeType = containmentEdges[retainerEdgeIndex + edgeTypeOffset];
+ if (retainerEdgeType === edgeWeakType)
+ continue;
var retainerNodeIndex = retainingNodes[retainerIndex];
if (retainerNodeIndex !== rootNodeIndex && retainerEdgeType === edgeShortcutType)
continue;

Powered by Google App Engine
This is Rietveld 408576698