Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 674443003: DevTools: ignore weak referenced when calculating dominators for heap snapshot (Closed)

Created:
6 years, 2 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: ignore weak referenced when calculating dominators for heap snapshot Oherwise retained size of an object would be affected by the references. BUG=425905 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184165

Patch Set 1 #

Total comments: 4

Patch Set 2 : Renamed test function named as suggested by loislo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M LayoutTests/inspector/profiler/heap-snapshot-test.js View 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/inspector/profiler/heap-snapshot-weak-dominator.html View 1 1 chunk +92 lines, -0 lines 0 comments Download
A LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
6 years, 2 months ago (2014-10-22 09:40:55 UTC) #2
loislo
lgtm with nits https://codereview.chromium.org/674443003/diff/1/LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt File LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt (right): https://codereview.chromium.org/674443003/diff/1/LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt#newcode5 LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt:5: Running: testRetainersAutoExpandSingleRetainer ditto https://codereview.chromium.org/674443003/diff/1/LayoutTests/inspector/profiler/heap-snapshot-weak-dominator.html File LayoutTests/inspector/profiler/heap-snapshot-weak-dominator.html ...
6 years, 2 months ago (2014-10-22 09:45:56 UTC) #3
yurys
https://codereview.chromium.org/674443003/diff/1/LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt File LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt (right): https://codereview.chromium.org/674443003/diff/1/LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt#newcode5 LayoutTests/inspector/profiler/heap-snapshot-weak-dominator-expected.txt:5: Running: testRetainersAutoExpandSingleRetainer On 2014/10/22 09:45:56, loislo wrote: > ditto ...
6 years, 2 months ago (2014-10-22 09:48:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674443003/20001
6 years, 2 months ago (2014-10-22 09:50:00 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 10:54:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184165

Powered by Google App Engine
This is Rietveld 408576698