Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/api.cc

Issue 674423002: Get stack trace for uncaught exceptions/promise rejections from the simple stack when available. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 695a644e57c85a3682b6d0d09080cc085159588b..c04393d8be1ec53c7b6fb0376447c4379e703ec4 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6960,12 +6960,7 @@ Local<StackTrace> Exception::GetStackTrace(Handle<Value> exception) {
i::Handle<i::JSObject> js_obj = i::Handle<i::JSObject>::cast(obj);
i::Isolate* isolate = js_obj->GetIsolate();
ENTER_V8(isolate);
- i::Handle<i::Name> key = isolate->factory()->detailed_stack_trace_symbol();
- i::Handle<i::Object> property = i::JSObject::GetDataProperty(js_obj, key);
- if (property->IsJSArray()) {
- return Utils::StackTraceToLocal(i::Handle<i::JSArray>::cast(property));
- }
- return Local<StackTrace>();
+ return Utils::StackTraceToLocal(isolate->GetDetailedStackTrace(js_obj));
}
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698