Get stack trace for uncaught exceptions/promise rejections from the simple stack when available.

Get stack trace for uncaught exceptions/promise rejections from the simple stack when available.

We can convert simple stack trace of an Error object to the detailed stack that
is used for debugging. Do so when available, and only then fall back to
reporting stack trace at throw site.

R=yangguo@chromium.org, Yang
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=24938

[Yang, 2014-10-27 11:44:39]

On 2014/10/27 11:38:47, aandrey wrote:

Do I understand correctly that this would only make a difference if the Error
object was created before V8::SetCaptureStackTraceForUncaughtExceptions(true)?
Note that this may not work if the stack property has been retrieved before we
turn the simple stack trace into the detailed stack trace.

[aandrey, 2014-10-27 12:30:34]

On 2014/10/27 11:44:39, Yang wrote:
> On 2014/10/27 11:38:47, aandrey wrote:
> 
> Do I understand correctly that this would only make a difference if the Error
> object was created before V8::SetCaptureStackTraceForUncaughtExceptions(true)?
> Note that this may not work if the stack property has been retrieved before we
> turn the simple stack trace into the detailed stack trace.

Correct. This is a first patch to address one of the most common real world use
cases: open DevTools when something bad has already happened.

It's OK if "e.stack" was called and we removed the simple stack. Although later
we could add a hook into runtime to convert it to the detailed stack first if
the capture_stack_trace_for_uncaught_exceptions_ is true.

[Yang, 2014-10-28 12:08:10]

LGTM with comments.

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode452
src/isolate.cc:452: error_object,
stack_trace_for_uncaught_exceptions_frame_limit_,
There is no need to pass those two arguments, since
GetDetailedStackTraceFromSimpleStack also has access to them on the Isolate.

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode558
src/isolate.cc:558: script->compilation_type() == Script::COMPILATION_TYPE_EVAL
you can use factory()->ToBoolean for this.

https://codereview.chromium.org/674423002/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/674423002/diff/1/src/isolate.h#newcode750
src/isolate.h:750: Handle<JSArray> GetDetailedStackTraceFromSimpleStack(
Naming is a bit weird in the way that you are calling it "SimpleStack" instead
of "SimpleStackTrace"

Maybe "GetDetailedFromSimpleStackTrace"?

[aandrey, 2014-10-28 13:12:14]

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode452
src/isolate.cc:452: error_object,
stack_trace_for_uncaught_exceptions_frame_limit_,
On 2014/10/28 12:08:10, Yang wrote:
> There is no need to pass those two arguments, since
> GetDetailedStackTraceFromSimpleStack also has access to them on the Isolate.

Done.

https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode558
src/isolate.cc:558: script->compilation_type() == Script::COMPILATION_TYPE_EVAL
On 2014/10/28 12:08:10, Yang wrote:
> you can use factory()->ToBoolean for this.

Done.

https://codereview.chromium.org/674423002/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/674423002/diff/1/src/isolate.h#newcode750
src/isolate.h:750: Handle<JSArray> GetDetailedStackTraceFromSimpleStack(
On 2014/10/28 12:08:10, Yang wrote:
> Naming is a bit weird in the way that you are calling it "SimpleStack" instead
> of "SimpleStackTrace"
> 
> Maybe "GetDetailedFromSimpleStackTrace"?

Done.

[Yang, 2014-10-28 13:13:58]

On 2014/10/28 13:12:14, aandrey wrote:
> https://codereview.chromium.org/674423002/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode452
> src/isolate.cc:452: error_object,
> stack_trace_for_uncaught_exceptions_frame_limit_,
> On 2014/10/28 12:08:10, Yang wrote:
> > There is no need to pass those two arguments, since
> > GetDetailedStackTraceFromSimpleStack also has access to them on the Isolate.
> 
> Done.
> 
> https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode558
> src/isolate.cc:558: script->compilation_type() ==
Script::COMPILATION_TYPE_EVAL
> On 2014/10/28 12:08:10, Yang wrote:
> > you can use factory()->ToBoolean for this.
> 
> Done.
> 
> https://codereview.chromium.org/674423002/diff/1/src/isolate.h
> File src/isolate.h (right):
> 
> https://codereview.chromium.org/674423002/diff/1/src/isolate.h#newcode750
> src/isolate.h:750: Handle<JSArray> GetDetailedStackTraceFromSimpleStack(
> On 2014/10/28 12:08:10, Yang wrote:
> > Naming is a bit weird in the way that you are calling it "SimpleStack"
instead
> > of "SimpleStackTrace"
> > 
> > Maybe "GetDetailedFromSimpleStackTrace"?
> 
> Done.

LGTM.

[aandrey, 2014-10-28 13:24:56]

Committed patchset #2 (id:20001) manually as 24938 (presubmit successful).