Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/add_watcher.h

Issue 674413002: [fsp] Rename ObserveEntry with AddWatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/add_watcher.h
diff --git a/chrome/browser/chromeos/file_system_provider/operations/observe_directory.h b/chrome/browser/chromeos/file_system_provider/operations/add_watcher.h
similarity index 71%
rename from chrome/browser/chromeos/file_system_provider/operations/observe_directory.h
rename to chrome/browser/chromeos/file_system_provider/operations/add_watcher.h
index e23852ce611a2807ab759cd1390fd84498213607..f4f5528bbbbcfd90b6f58121bcaba2adbcc896a2 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/observe_directory.h
+++ b/chrome/browser/chromeos/file_system_provider/operations/add_watcher.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_OBSERVE_DIRECTORY_H_
-#define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_OBSERVE_DIRECTORY_H_
+#ifndef CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_ADD_WATCHER_H_
+#define CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_ADD_WATCHER_H_
#include "base/files/file.h"
#include "base/memory/scoped_ptr.h"
@@ -25,16 +25,17 @@ namespace chromeos {
namespace file_system_provider {
namespace operations {
-// Observes a directory. If |recursive| is true, than also observes all of the
-// child entries in within, recursively.
-class ObserveDirectory : public Operation {
+// Adds a watcher. If |recursive| is true, than also watches for all of the
+// child entries in within, recursively. Recursive must not be set to true for
+// files.
+class AddWatcher : public Operation {
public:
- ObserveDirectory(extensions::EventRouter* event_router,
- const ProvidedFileSystemInfo& file_system_info,
- const base::FilePath& directory_path,
- bool recursive,
- const storage::AsyncFileUtil::StatusCallback& callback);
- virtual ~ObserveDirectory();
+ AddWatcher(extensions::EventRouter* event_router,
+ const ProvidedFileSystemInfo& file_system_info,
+ const base::FilePath& entry_path,
+ bool recursive,
+ const storage::AsyncFileUtil::StatusCallback& callback);
+ virtual ~AddWatcher();
// Operation overrides.
virtual bool Execute(int request_id) override;
@@ -46,15 +47,15 @@ class ObserveDirectory : public Operation {
base::File::Error error) override;
private:
- const base::FilePath directory_path_;
+ const base::FilePath entry_path_;
const bool recursive_;
const storage::AsyncFileUtil::StatusCallback callback_;
- DISALLOW_COPY_AND_ASSIGN(ObserveDirectory);
+ DISALLOW_COPY_AND_ASSIGN(AddWatcher);
};
} // namespace operations
} // namespace file_system_provider
} // namespace chromeos
-#endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_OBSERVE_DIRECTORY_H_
+#endif // CHROME_BROWSER_CHROMEOS_FILE_SYSTEM_PROVIDER_OPERATIONS_ADD_WATCHER_H_

Powered by Google App Engine
This is Rietveld 408576698