Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67433002: Move Mac related files to Source/platform (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dsinclair, shans, danakj, dstockwell, Timothy Loh, Rik, Steve Block, darktears, Stephen Chennney, Eric Willigers, dino_apple.com, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move Mac related files to Source/platform Some files in Source/core/platform/graphics depend on these BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161693

Patch Set 1 #

Patch Set 2 : Try to add exporting #

Total comments: 1

Patch Set 3 : another attempt af fixing link error #

Patch Set 4 : Also export BlockExceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -410 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/mac/FontCacheMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/mac/SimpleFontDataMac.mm View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/mac/BlockExceptions.h View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/core/platform/mac/BlockExceptions.mm View 1 chunk +0 lines, -38 lines 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mac/ThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/mac/WebFontCache.h View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/platform/mac/WebFontCache.mm View 1 chunk +0 lines, -294 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + Source/platform/mac/BlockExceptions.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A + Source/platform/mac/BlockExceptions.mm View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/mac/WebFontCache.h View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/mac/WebFontCache.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
Not sure about the PLATFORM_EXPORT here, maybe we can first try the Mac trybot.
7 years, 1 month ago (2013-11-08 22:41:40 UTC) #1
Stephen Chennney
LGTM with one nit. You can CQ once you upload a fix for the gypi ...
7 years, 1 month ago (2013-11-09 12:12:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/67433002/110001
7 years, 1 month ago (2013-11-09 22:43:13 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-09 23:22:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/67433002/80005
7 years, 1 month ago (2013-11-09 23:35:32 UTC) #5
commit-bot: I haz the power
Change committed as 161693
7 years, 1 month ago (2013-11-10 00:48:56 UTC) #6
Avi (use Gerrit)
On 2013/11/10 00:48:56, I haz the power (commit-bot) wrote: > Change committed as 161693 FYI, ...
7 years, 1 month ago (2013-11-10 23:30:52 UTC) #7
rwlbuis
7 years, 1 month ago (2013-11-11 15:21:30 UTC) #8
Message was sent while issue was closed. 
On 2013/11/10 23:30:52, Avi wrote:
> On 2013/11/10 00:48:56, I haz the power (commit-bot) wrote:
> > Change committed as 161693
> 
> FYI, PLATFORM_EXPORT is needed for component builds, which the trybots don't
do.
> This broke the Mac 64 component build; I will post a fix.

Sorry about that, I'll switch to component build from now on on my mac.

Powered by Google App Engine
This is Rietveld 408576698