Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 674303002: Remove stub ScrollEndEffectController (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 1 month ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@athena_do_not_use_ash4_wallpaper
Project:
chromium
Visibility:
Public.

Description

Remove stub ScrollEndEffectController BUG=426561 TEST=None Committed: https://crrev.com/9d751807d4667c968761e33068de320a5a3f74f9 Cr-Commit-Position: refs/heads/master@{#301515}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/views/frame/scroll_end_effect_controller.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/views/frame/scroll_end_effect_controller_ash.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/views/frame/scroll_end_effect_controller_ash.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
pkotwicz
Sadrul, can you please take a look? If we actually want to implement the scroll ...
6 years, 2 months ago (2014-10-25 04:57:59 UTC) #2
sadrul
LGTM!
6 years, 1 month ago (2014-10-27 14:19:27 UTC) #3
pkotwicz
sky@ for OWNERS
6 years, 1 month ago (2014-10-27 15:10:46 UTC) #5
sky
LGTM
6 years, 1 month ago (2014-10-27 15:30:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674303002/1
6 years, 1 month ago (2014-10-27 16:50:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78936)
6 years, 1 month ago (2014-10-27 17:02:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674303002/20001
6 years, 1 month ago (2014-10-27 21:24:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/3687)
6 years, 1 month ago (2014-10-27 22:31:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674303002/20001
6 years, 1 month ago (2014-10-27 23:20:16 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-28 00:32:42 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 00:33:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d751807d4667c968761e33068de320a5a3f74f9
Cr-Commit-Position: refs/heads/master@{#301515}

Powered by Google App Engine
This is Rietveld 408576698