Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 674273002: Cleanup: Remove unneeded chrome/common/pref_names.h includes. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), skanuj+watch_chromium.org, felt, nkostylev+watch_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, dcheng, Dmitry Titov, dmazzoni+watch_chromium.org, sadrul, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, melevin+watch_chromium.org, tommycli, aboxhall+watch_chromium.org, grt+watch_chromium.org, dyu1, shishir+watch_chromium.org, benquan, rlp+watch_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Dane Wallinga, dbeam+watch-options_chromium.org, marja+watch_chromium.org, jennb, Greg Billock, eroman, chrome-apps-syd-reviews_chromium.org, tburkard+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, Jered, feature-media-reviews_chromium.org, samarth+watch_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, jianli, oshima+watch_chromium.org, Michael van Ouwerkerk, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, Ilya Sherman, kalyank, plundblad+watch_chromium.org, gavinp+prer_chromium.org, Lei Zhang, tfarina, ben+ash_chromium.org, donnd+watch_chromium.org, mcasas+watch_chromium.org, yurys, pvalenzuela+watch_chromium.org, benjhayden+dwatch_chromium.org, jfweitz+watch_chromium.org, David Black, davemoore+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, peter+watch_chromium.org, James Su, wjia+watch_chromium.org, mmenke, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded chrome/common/pref_names.h includes. Committed: https://crrev.com/7e3b19daf0dc79aaae172a71f8dbf34c6cb23292 Cr-Commit-Position: refs/heads/master@{#301486}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -109 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_page_zoom.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/charger_replace/charger_link_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/auth_sync_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/blacklist.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/policy_handlers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/policy_handlers_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_startup_installer_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/message_center_notification_manager_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/fake_signin_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_feedback_dialog_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_feedback_dialog_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media/webrtc_logs_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/reset_profile_settings_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/login_ui_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
stampy stamp
6 years, 1 month ago (2014-10-25 01:19:36 UTC) #2
Elliot Glaysher
lgtm stamp
6 years, 1 month ago (2014-10-27 16:53:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674273002/1
6 years, 1 month ago (2014-10-27 18:17:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/27983) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20316) linux_chromium_asan_rel ...
6 years, 1 month ago (2014-10-27 18:27:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674273002/20001
6 years, 1 month ago (2014-10-27 21:04:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 23:43:31 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:44:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e3b19daf0dc79aaae172a71f8dbf34c6cb23292
Cr-Commit-Position: refs/heads/master@{#301486}

Powered by Google App Engine
This is Rietveld 408576698