Add remaining text/caret navigation commands to ChromeVox Next.

chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The entry point for all ChromeVox2 related code for the
  * background page.
  */
 
 goog.provide('Background');
@@ skipping 126 matching lines @@
     var pred = null;
     switch (command) {
       case 'nextHeading':
         dir = Dir.FORWARD;
         pred = AutomationPredicate.heading;
         break;
       case 'previousHeading':
         dir = Dir.BACKWARD;
         pred = AutomationPredicate.heading;
         break;
+      case 'nextCharacter':
+        current = current.move(cursors.Unit.CHARACTER, Dir.FORWARD);
+        break;
+      case 'previousCharacter':
+        current = current.move(cursors.Unit.CHARACTER, Dir.BACKWARD);
+        break;
+      case 'nextWord':
+        current = current.move(cursors.Unit.WORD, Dir.FORWARD);
+        break;
+      case 'previousWord':
+        current = current.move(cursors.Unit.WORD, Dir.BACKWARD);
+        break;
       case 'nextLine':
         current = current.move(cursors.Unit.LINE, Dir.FORWARD);
         break;
       case 'previousLine':
         current = current.move(cursors.Unit.LINE, Dir.BACKWARD);
         break;
       case 'nextLink':
         dir = Dir.FORWARD;
         pred = AutomationPredicate.link;
         break;
@@ skipping 154 matching lines @@
     var nodeLocations = [];
     while (cursor.getNode() != range.getEnd().getNode()) {
       output += getCursorDesc(cursor);
       nodeLocations.push(cursor.getNode().location);
       cursor = cursor.move(
           cursors.Unit.NODE, cursors.Movement.DIRECTIONAL, Dir.FORWARD);
     }
     output += getCursorDesc(range.getEnd());
     nodeLocations.push(range.getEnd().getNode().location);
 
+    // Read subnode ranges.
+    if (range.getStart().getNode() === range.getEnd().getNode()) {

[dmazzoni, 2014/10/27 07:06:20]

Suppose I'm moving by words and I move from the last word of one paragraph to
the first word of the next element, which happens to be a heading. This code
would have it read just the first word of the heading, and I think it'd drop the
role. Do you think it should still output "heading", or something like "entering
heading"?

As usual, you don't have to solve this issue completely, but I'd like to figure
out what the intended behavior is and how the code should be structured to
support it.

Just looking at the code, it feels wrong to compute the output and then replace
it in this special case here.

Oh - I'm also wondering if it makes sense for this code to trigger if you have a
range that spans from the first to the last character of a node, as opposed to a
range that just spans that node's element - is there any way we could make it so
that those two cases behave identically?

+      var startIndex = range.getStart().getIndex();
+      var endIndex = range.getEnd().getIndex();
+      if (startIndex > -1 && endIndex > -1)
+        output = range.getStart().getText().substring(startIndex, endIndex);
+    }
+
     cvox.ChromeVox.tts.speak(output, cvox.QueueMode.FLUSH);
     cvox.ChromeVox.braille.write(cvox.NavBraille.fromText(output));
     chrome.accessibilityPrivate.setFocusRing(nodeLocations);
   }
 };
 
 /** @type {Background} */
 global.backgroundObj = new Background();
 
 });  // goog.scope