SkVarAlloc

SkVarAlloc

Like SkChunkAlloc, but
  - does its allocation with better sympathy for malloc granularity;
  - the fast path inlines entirely;
  - smaller per-block overhead;
  - smaller per-SkVarAlloc overhead;
  - growth parameters are a little more tunable.

Its main downside is less flexibility; it supports fewer methods than SkChunkAlloc.

These current parameters bring the first allocation down from 4K to 1K,
without affecting recording time on my desktop.  skiaperf.com will tell the
whole story.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/8113dd13692bc2e1fe804141d04b2cc5f03a55be

[mtklein, 2014-11-12 21:57:51]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[mtklein, 2014-11-12 22:02:30]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-12 22:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674263002/20001

[commit-bot: I haz the power, 2014-11-12 22:02:44]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-13 04:02 UTC

[reed1, 2014-11-12 22:12:25]

lgtm w/ comments

https://codereview.chromium.org/674263002/diff/20001/src/core/SkVarAlloc.cpp
File src/core/SkVarAlloc.cpp (right):

https://codereview.chromium.org/674263002/diff/20001/src/core/SkVarAlloc.cpp#...
src/core/SkVarAlloc.cpp:48: fSmallest = SkToUInt(fSmallest * fGrowth);
I think you may get warnings about float->int conversion here.
I do like the cast to uint to catch the size_t down cast.

[mtklein, 2014-11-12 22:23:39]

https://codereview.chromium.org/674263002/diff/20001/src/core/SkVarAlloc.cpp
File src/core/SkVarAlloc.cpp (right):

https://codereview.chromium.org/674263002/diff/20001/src/core/SkVarAlloc.cpp#...
src/core/SkVarAlloc.cpp:48: fSmallest = SkToUInt(fSmallest * fGrowth);
On 2014/11/12 22:12:25, reed1 wrote:
> I think you may get warnings about float->int conversion here.
> I do like the cast to uint to catch the size_t down cast.

Now explicitly truncating.

[mtklein, 2014-11-12 22:23:42]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-12 22:23:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674263002/40001

[commit-bot: I haz the power, 2014-11-12 22:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 22:41:04]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[mtklein, 2014-11-12 22:49:10]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-12 22:50:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674263002/40001

[commit-bot: I haz the power, 2014-11-12 23:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 23:05:53]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[mtklein, 2014-11-12 23:06:40]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-12 23:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674263002/40001

[commit-bot: I haz the power, 2014-11-12 23:15:32]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8113dd13692bc2e1fe804141d04b2cc5f03a55be