cc: Make consistent use of bounds() versus the pile's size.

cc: Make consistent use of bounds() versus the pile's size.

In PictureLayerImpl we assume that the pile size matches the bounds but
this is subtley not true when the layer is not part of the visible
frame (ie. not in the RenderSurfaceLayerList).

So use the pile's size consistently everywhere except during drawing
where using the bounds makes some logical sense. And DCHECK they are
equal there.

R=enne, vmpstr

Committed: https://crrev.com/7b4cac771543aaa4f424fb468573a79891eab5cb
Cr-Commit-Position: refs/heads/master@{#301366}

[danakj, 2014-10-24 22:51:55]

now with passing tests and only 1 tile manager ^_^b

[vmpstr, 2014-10-24 22:55:12]

lgtm, thanks for tracking down the test weirdness!

[enne (OOO), 2014-10-24 23:06:42]

lgtm as well!

I was a little not sure about the "use bounds() in AppendQuads", but I guess the
draw transform is based on what the bounds are.  And, the only time you're wrong
would be if somehow you missed update but got drawn (like a RSLL mismatch
between threads).  It might be worth leaving a comment as to why that DCHECK
could fail while the knowledge is still fresh.

Thanks also for cleaning up for use of bounds vs content_bounds too.

[danakj, 2014-10-24 23:10:45]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-10-24 23:11:00]

Thanks, commented.

On Fri, Oct 24, 2014 at 7:06 PM, <enne@chromium.org> wrote:

> lgtm as well!
>
> I was a little not sure about the "use bounds() in AppendQuads", but I
> guess the
> draw transform is based on what the bounds are.  And, the only time you're
> wrong
> would be if somehow you missed update but got drawn (like a RSLL mismatch
> between threads).  It might be worth leaving a comment as to why that
> DCHECK
> could fail while the knowledge is still fresh.
>
> Thanks also for cleaning up for use of bounds vs content_bounds too.
>
> https://codereview.chromium.org/674253002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-10-24 23:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674253002/60001

[danakj, 2014-10-24 23:14:06]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-24 23:14:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674253002/80001

[commit-bot: I haz the power, 2014-10-24 23:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 23:29:15]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[danakj, 2014-10-27 14:43:03]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-27 14:44:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674253002/100001

[commit-bot: I haz the power, 2014-10-27 15:33:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-27 15:34:32]

Patchset 6 (id:??) landed as
https://crrev.com/7b4cac771543aaa4f424fb468573a79891eab5cb
Cr-Commit-Position: refs/heads/master@{#301366}