Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 674203005: PPAPI: Make TestMessageHandler.Exceptions work (Closed)

Created:
6 years, 2 months ago by dmichael (off chromium)
Modified:
6 years, 1 month ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Make TestMessageHandler.Exceptions work Currently, the second half of the test doesn't actually do anything. This patch makes the second half of the test run. Fortunately, it already works :) BUG= Committed: https://crrev.com/8fcb4bfde9d49a4c46ac1565083c150407cbf7aa Cr-Commit-Position: refs/heads/master@{#301418}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M ppapi/tests/test_message_handler.h View 1 chunk +5 lines, -3 lines 0 comments Download
M ppapi/tests/test_message_handler.cc View 1 11 chunks +52 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dmichael (off chromium)
https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc File ppapi/tests/test_message_handler.cc (left): https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc#oldcode118 ppapi/tests/test_message_handler.cc:118: testing_instance_->PostMessage(var); This "echo" was unused https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc#oldcode335 ppapi/tests/test_message_handler.cc:335: message_received_.Wait(); I ...
6 years, 2 months ago (2014-10-24 21:06:21 UTC) #3
teravest
https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc File ppapi/tests/test_message_handler.cc (right): https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc#newcode45 ppapi/tests/test_message_handler.cc:45: class MockMessageHandler : public pp::MessageHandler { I'm not sure ...
6 years, 1 month ago (2014-10-26 21:09:07 UTC) #4
dmichael (off chromium)
https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc File ppapi/tests/test_message_handler.cc (right): https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc#newcode45 ppapi/tests/test_message_handler.cc:45: class MockMessageHandler : public pp::MessageHandler { On 2014/10/26 21:09:07, ...
6 years, 1 month ago (2014-10-27 16:30:39 UTC) #5
teravest
On Mon, Oct 27, 2014 at 10:30 AM, <dmichael@chromium.org> wrote: > > https://codereview.chromium.org/674203005/diff/20001/ppapi/tests/test_message_handler.cc > File ...
6 years, 1 month ago (2014-10-27 16:51:36 UTC) #6
dmichael (off chromium)
That's already in the latest patch. Does it lgty? On Mon, Oct 27, 2014 at ...
6 years, 1 month ago (2014-10-27 16:57:50 UTC) #7
teravest
lgtm
6 years, 1 month ago (2014-10-27 18:41:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674203005/40001
6 years, 1 month ago (2014-10-27 18:57:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-10-27 19:43:03 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:43:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fcb4bfde9d49a4c46ac1565083c150407cbf7aa
Cr-Commit-Position: refs/heads/master@{#301418}

Powered by Google App Engine
This is Rietveld 408576698