Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 674193003: Remove //content/shell/layout_tests/. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, Mike West
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove //content/shell/layout_tests/. The last change to the TestExpectations file was made in January 2013, and nothing is referring to it (or this directory) anymore. BUG= Committed: https://crrev.com/8194a9f9da1c58df8fafbf68d4dae63263b3813b Cr-Commit-Position: refs/heads/master@{#301476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
D content/shell/layout_tests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
I checked Chromium, a bunch of infra repositories as well as internal code search and ...
6 years, 1 month ago (2014-10-27 16:47:02 UTC) #2
Mike West
Don't we need this as the first side of a three-sided-patch when we roll changes ...
6 years, 1 month ago (2014-10-27 16:49:48 UTC) #3
Peter Beverloo
On 2014/10/27 16:49:48, Mike West wrote: > Don't we need this as the first side ...
6 years, 1 month ago (2014-10-27 16:53:12 UTC) #5
Dirk Pranke
lgtm. This file dates from the time when we were still doing the DRT -> ...
6 years, 1 month ago (2014-10-27 21:55:25 UTC) #6
Mike West
ok. LGTM 2. :)
6 years, 1 month ago (2014-10-27 21:56:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674193003/1
6 years, 1 month ago (2014-10-27 21:59:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:16:07 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:17:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8194a9f9da1c58df8fafbf68d4dae63263b3813b
Cr-Commit-Position: refs/heads/master@{#301476}

Powered by Google App Engine
This is Rietveld 408576698