Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 674183002: Drop unnecessary toString() in interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/parser.dart ('k') | pkg/analyzer/lib/src/generated/scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 1717d76b54f8d928a70d76aad5da0f29afa30e1d..bcc7ad340a3d25aecdfa7561072d9543bbc1b82f 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -4636,7 +4636,7 @@ class ElementHolder {
builder.append(" type parameters");
}
if (builder.length > 0) {
- AnalysisEngine.instance.logger.logError("Failed to capture elements: ${builder.toString()}");
+ AnalysisEngine.instance.logger.logError("Failed to capture elements: $builder");
}
}
}
@@ -14289,7 +14289,7 @@ class IncrementalResolver {
bool _elementModelChanged(AstNode node) {
Element element = _getElement(node);
if (element == null) {
- throw new AnalysisException("Cannot resolve node: a ${node.runtimeType.toString()} does not define an element");
+ throw new AnalysisException("Cannot resolve node: a ${node.runtimeType} does not define an element");
}
DeclarationMatcher matcher = new DeclarationMatcher();
return !matcher.matches(node, element);
@@ -15181,7 +15181,7 @@ class InheritanceManager {
// of the other, we create a warning, and have this class inherit nothing.
//
if (!classHasMember) {
- String firstTwoFuntionTypesStr = "${executableElementTypes[0].toString()}, ${executableElementTypes[1].toString()}";
+ String firstTwoFuntionTypesStr = "${executableElementTypes[0]}, ${executableElementTypes[1]}";
_reportError(classElt, classElt.nameOffset, classElt.displayName.length, StaticTypeWarningCode.INCONSISTENT_METHOD_INHERITANCE, [key, firstTwoFuntionTypesStr]);
}
} else {
@@ -17895,7 +17895,7 @@ class NamespaceBuilder {
definedNames = _show(definedNames, combinator.shownNames);
} else {
// Internal error.
- AnalysisEngine.instance.logger.logError("Unknown type of combinator: ${combinator.runtimeType.toString()}");
+ AnalysisEngine.instance.logger.logError("Unknown type of combinator: ${combinator.runtimeType}");
}
}
return definedNames;
@@ -18815,7 +18815,7 @@ class ResolverErrorCode extends Enum<ResolverErrorCode> implements ErrorCode {
ErrorSeverity get errorSeverity => type.severity;
@override
- String get uniqueName => "${runtimeType.toString()}.${name}";
+ String get uniqueName => "$runtimeType.$name";
}
/**
« no previous file with comments | « pkg/analyzer/lib/src/generated/parser.dart ('k') | pkg/analyzer/lib/src/generated/scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698