Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 674183002: Drop unnecessary toString() in interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/error.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index ea758e79a78661fa3ca68d9aacd219e7ebec87e4..654872af46bbf618cbe0291f52f55db63d47e2b0 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -1209,7 +1209,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
return _getDartScanData2(source, SourceEntry.LINE_INFO, null);
}
} on ObsoleteSourceAnalysisException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Could not compute ${SourceEntry.LINE_INFO.toString()}", exception);
+ AnalysisEngine.instance.logger.logInformation2("Could not compute ${SourceEntry.LINE_INFO}", exception);
}
return null;
}
@@ -2836,7 +2836,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
try {
return _getDartParseData(source, dartEntry, descriptor);
} on ObsoleteSourceAnalysisException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Could not compute ${descriptor.toString()}", exception);
+ AnalysisEngine.instance.logger.logInformation2("Could not compute $descriptor", exception);
return defaultValue;
}
}
@@ -2890,7 +2890,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
try {
return _getDartResolutionData(unitSource, librarySource, dartEntry, descriptor);
} on ObsoleteSourceAnalysisException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Could not compute ${descriptor.toString()}", exception);
+ AnalysisEngine.instance.logger.logInformation2("Could not compute $descriptor", exception);
return defaultValue;
}
}
@@ -2935,7 +2935,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
try {
return _getDartScanData(source, dartEntry, descriptor);
} on ObsoleteSourceAnalysisException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Could not compute ${descriptor.toString()}", exception);
+ AnalysisEngine.instance.logger.logInformation2("Could not compute $descriptor", exception);
return defaultValue;
}
}
@@ -3009,7 +3009,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
try {
return _getHtmlResolutionData2(source, htmlEntry, descriptor);
} on ObsoleteSourceAnalysisException catch (exception) {
- AnalysisEngine.instance.logger.logInformation2("Could not compute ${descriptor.toString()}", exception);
+ AnalysisEngine.instance.logger.logInformation2("Could not compute $descriptor", exception);
return defaultValue;
}
}
@@ -10852,7 +10852,7 @@ class ParseDartTask extends AnalysisTask {
_includedSources.add(referencedSource);
}
} else {
- throw new AnalysisException("${runtimeType.toString()} failed to handle a ${directive.runtimeType.toString()}");
+ throw new AnalysisException("$runtimeType failed to handle a ${directive.runtimeType}");
}
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/element.dart ('k') | pkg/analyzer/lib/src/generated/error.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698