Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2853)

Issue 674163002: Test that only the right resource is loaded in iframes. (Closed)

Created:
6 years, 1 month ago by Yoav Weiss
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Test that only the right resource is loaded in iframes. Adding a couple of tests to make sure that the right resource is loaded when srcset is inside an iframe, and that *only* the right resource is loaded. BUG=425909 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184373

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html View 1 chunk +29 lines, -0 lines 1 comment Download
A LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe-external.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe-external-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLImageElement/resources/srcset_iframe.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yoav Weiss
6 years, 1 month ago (2014-10-24 15:08:20 UTC) #2
Yoav Weiss
6 years, 1 month ago (2014-10-24 15:08:20 UTC) #3
Mike West
LGTM % note. https://codereview.chromium.org/674163002/diff/1/LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html File LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html (right): https://codereview.chromium.org/674163002/diff/1/LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html#newcode2 LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html:2: <script src="../../../resources/js-test.js"></script> Can you (perhaps in ...
6 years, 1 month ago (2014-10-24 15:18:26 UTC) #4
Yoav Weiss
On 2014/10/24 15:18:26, Mike West wrote: > LGTM % note. > > https://codereview.chromium.org/674163002/diff/1/LayoutTests/fast/dom/HTMLImageElement/image-srcset-in-iframe.html > File ...
6 years, 1 month ago (2014-10-24 15:20:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674163002/1
6 years, 1 month ago (2014-10-24 15:21:49 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 17:02:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184373

Powered by Google App Engine
This is Rietveld 408576698