Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: minidump/minidump_stream_writer.h

Issue 674153002: minidump: Change the ownership model (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« minidump/minidump_memory_writer.h ('K') | « minidump/minidump_simple_string_dictionary_writer_test.cc ('k') | minidump/minidump_stream_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_stream_writer.h
diff --git a/minidump/minidump_stream_writer.h b/minidump/minidump_stream_writer.h
index 4fb5b89c3fb9c205cd6ef78be5e9fb4197ba2464..0cd1d03b970ea1d1407fd3748d87b88880ce4764 100644
--- a/minidump/minidump_stream_writer.h
+++ b/minidump/minidump_stream_writer.h
@@ -31,6 +31,8 @@ namespace internal {
//! MinidumpFileWriter object.
class MinidumpStreamWriter : public MinidumpWritable {
public:
+ virtual ~MinidumpStreamWriter();
Robert Sesek 2014/10/27 17:18:00 Same: override.
+
//! \brief Returns an object’s stream type.
//!
//! \note Valid in any state.
@@ -47,7 +49,6 @@ class MinidumpStreamWriter : public MinidumpWritable {
protected:
MinidumpStreamWriter();
- ~MinidumpStreamWriter() {}
// MinidumpWritable:
bool Freeze() override;
« minidump/minidump_memory_writer.h ('K') | « minidump/minidump_simple_string_dictionary_writer_test.cc ('k') | minidump/minidump_stream_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698