Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: minidump/minidump_string_writer.h

Issue 674153002: minidump: Change the ownership model (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_stream_writer.cc ('k') | minidump/minidump_string_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_string_writer.h
diff --git a/minidump/minidump_string_writer.h b/minidump/minidump_string_writer.h
index 9c0e609716952797589d8f7f05b0de8363db2678..bde25b5c535f2ca15ffc8c73e1996a210a9a76cf 100644
--- a/minidump/minidump_string_writer.h
+++ b/minidump/minidump_string_writer.h
@@ -51,7 +51,7 @@ template <typename Traits>
class MinidumpStringWriter : public MinidumpWritable {
public:
MinidumpStringWriter();
- ~MinidumpStringWriter();
+ ~MinidumpStringWriter() override;
protected:
typedef typename Traits::MinidumpStringType MinidumpStringType;
@@ -87,7 +87,7 @@ class MinidumpUTF16StringWriter final
: public MinidumpStringWriter<MinidumpStringWriterUTF16Traits> {
public:
MinidumpUTF16StringWriter() : MinidumpStringWriter() {}
- ~MinidumpUTF16StringWriter() {}
+ ~MinidumpUTF16StringWriter() override;
//! \brief Converts a UTF-8 string to UTF-16 and sets it as the string to be
//! written.
@@ -108,7 +108,7 @@ class MinidumpUTF8StringWriter final
: public MinidumpStringWriter<MinidumpStringWriterUTF8Traits> {
public:
MinidumpUTF8StringWriter() : MinidumpStringWriter() {}
- ~MinidumpUTF8StringWriter() {}
+ ~MinidumpUTF8StringWriter() override;
//! \brief Sets the string to be written.
//!
« no previous file with comments | « minidump/minidump_stream_writer.cc ('k') | minidump/minidump_string_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698