minidump/minidump_stream_writer.h - Issue 674153002: minidump: Change the ownership model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_stream_writer.h

Issue 674153002: minidump: Change the ownership model (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_stream_writer.h

diff --git a/minidump/minidump_stream_writer.h b/minidump/minidump_stream_writer.h

index 4fb5b89c3fb9c205cd6ef78be5e9fb4197ba2464..b3270053f7c7b6f099ef944e0ead30aa38418355 100644

--- a/minidump/minidump_stream_writer.h

+++ b/minidump/minidump_stream_writer.h

@@ -31,6 +31,8 @@ namespace internal {

//! MinidumpFileWriter object.

class MinidumpStreamWriter : public MinidumpWritable {

public:

+ ~MinidumpStreamWriter() override;

//! \brief Returns an object’s stream type.

//!

//! \note Valid in any state.

@@ -47,7 +49,6 @@ class MinidumpStreamWriter : public MinidumpWritable {

protected:

MinidumpStreamWriter();

- ~MinidumpStreamWriter() {}

// MinidumpWritable:

bool Freeze() override;