minidump/minidump_misc_info_writer.h - Issue 674153002: minidump: Change the ownership model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_misc_info_writer.h

Issue 674153002: minidump: Change the ownership model (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_misc_info_writer.h

diff --git a/minidump/minidump_misc_info_writer.h b/minidump/minidump_misc_info_writer.h

index 8a741746f9768372382f5541b941527aac8d030c..0ca5482608f13cc1c5e94dcce10dd0b8a20bcacd 100644

--- a/minidump/minidump_misc_info_writer.h

+++ b/minidump/minidump_misc_info_writer.h

@@ -39,7 +39,7 @@ namespace crashpad {

class MinidumpMiscInfoWriter final : public internal::MinidumpStreamWriter {

public:

MinidumpMiscInfoWriter();

- ~MinidumpMiscInfoWriter() {}

+ ~MinidumpMiscInfoWriter() override;

//! \brief Sets the field referenced by #MINIDUMP_MISC1_PROCESS_ID.

void SetProcessId(uint32_t process_id);

« no previous file with comments | « minidump/minidump_memory_writer_test.cc ('k') | minidump/minidump_misc_info_writer.cc » ('j') | no next file with comments »