minidump/minidump_crashpad_info_writer.cc - Issue 674153002: minidump: Change the ownership model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_crashpad_info_writer.cc

Issue 674153002: minidump: Change the ownership model (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_crashpad_info_writer.cc

diff --git a/minidump/minidump_crashpad_info_writer.cc b/minidump/minidump_crashpad_info_writer.cc

index 5114843c33a74eccd424e1c0a2d9202b5a53f644..22be59773c83811d914dab003d2fb1dc2739005b 100644

--- a/minidump/minidump_crashpad_info_writer.cc

+++ b/minidump/minidump_crashpad_info_writer.cc

@@ -29,10 +29,10 @@ MinidumpCrashpadInfoWriter::~MinidumpCrashpadInfoWriter() {

}

void MinidumpCrashpadInfoWriter::SetModuleList(

- MinidumpModuleCrashpadInfoListWriter* module_list) {

+ scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list) {

DCHECK_EQ(state(), kStateMutable);

- module_list_ = module_list;

+ module_list_ = module_list.Pass();

}

bool MinidumpCrashpadInfoWriter::Freeze() {

@@ -61,7 +61,7 @@ MinidumpCrashpadInfoWriter::Children() {

std::vector<MinidumpWritable*> children;

if (module_list_) {

- children.push_back(module_list_);

+ children.push_back(module_list_.get());

}

return children;