minidump: Change the ownership model

minidump/minidump_module_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 41 matching lines @@
   ASSERT_EQ(kMinidumpStreamTypeModuleList, directory[0].StreamType);
   EXPECT_EQ(kModuleListStreamOffset, directory[0].Location.Rva);
 
   *module_list = MinidumpWritableAtLocationDescriptor<MINIDUMP_MODULE_LIST>(
       file_contents, directory[0].Location);
   ASSERT_TRUE(module_list);
 }
 
 TEST(MinidumpModuleWriter, EmptyModuleList) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
 
-  minidump_file_writer.AddStream(&module_list_writer);
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   ASSERT_EQ(sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MODULE_LIST),
             file_writer.string().size());
 
   const MINIDUMP_MODULE_LIST* module_list;
   ASSERT_NO_FATAL_FAILURE(
@@ skipping 183 matching lines @@
 
   ASSERT_NO_FATAL_FAILURE(ExpectMiscellaneousDebugRecord(&observed->MiscRecord,
                                                          file_contents,
                                                          expected_debug_name,
                                                          expected_debug_type,
                                                          expected_debug_utf16));
 }
 
 TEST(MinidumpModuleWriter, EmptyModule) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
 
   const char kModuleName[] = "test_executable";
 
-  MinidumpModuleWriter module_writer;
-  module_writer.SetName(kModuleName);
+  auto module_writer = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer->SetName(kModuleName);
 
-  module_list_writer.AddModule(&module_writer);
-  minidump_file_writer.AddStream(&module_list_writer);
+  module_list_writer->AddModule(module_writer.Pass());
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   ASSERT_GT(file_writer.string().size(),
             sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MODULE_LIST) + 1 * sizeof(MINIDUMP_MODULE));
 
   const MINIDUMP_MODULE_LIST* module_list;
   ASSERT_NO_FATAL_FAILURE(
@@ skipping 10 matching lines @@
                                        nullptr,
                                        0,
                                        0,
                                        nullptr,
                                        0,
                                        false));
 }
 
 TEST(MinidumpModuleWriter, OneModule) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
 
   const char kModuleName[] = "statically_linked";
   const uint64_t kModuleBase = 0x10da69000;
   const uint32_t kModuleSize = 0x1000;
   const uint32_t kChecksum = 0x76543210;
   const time_t kTimestamp = 0x386d4380;
   const uint32_t kFileVersionMS = 0x00010002;
   const uint32_t kFileVersionLS = 0x00030004;
   const uint32_t kProductVersionMS = 0x00050006;
   const uint32_t kProductVersionLS = 0x00070008;
   const uint32_t kFileFlagsMask = VS_FF_DEBUG | VS_FF_PRERELEASE |
                                   VS_FF_PATCHED | VS_FF_PRIVATEBUILD |
                                   VS_FF_INFOINFERRED | VS_FF_SPECIALBUILD;
   const uint32_t kFileFlags = VS_FF_PRIVATEBUILD | VS_FF_SPECIALBUILD;
   const uint32_t kFileOS = VOS_DOS;
   const uint32_t kFileType = VFT_DRV;
   const uint32_t kFileSubtype = VFT2_DRV_KEYBOARD;
   const char kPDBName[] = "statical.pdb";
   const uint8_t kPDBUUIDBytes[16] =
       {0xfe, 0xdc, 0xba, 0x98, 0x76, 0x54, 0x32, 0x10,
        0x08, 0x19, 0x2a, 0x3b, 0x4c, 0x5d, 0x6e, 0x7f};
   UUID pdb_uuid;
   pdb_uuid.InitializeFromBytes(kPDBUUIDBytes);
   const uint32_t kPDBAge = 1;
   const uint32_t kDebugType = IMAGE_DEBUG_MISC_EXENAME;
   const char kDebugName[] = "statical.dbg";
   const bool kDebugUTF16 = false;
 
-  MinidumpModuleWriter module_writer;
-  module_writer.SetName(kModuleName);
-  module_writer.SetImageBaseAddress(kModuleBase);
-  module_writer.SetImageSize(kModuleSize);
-  module_writer.SetChecksum(kChecksum);
-  module_writer.SetTimestamp(kTimestamp);
-  module_writer.SetFileVersion(kFileVersionMS >> 16,
-                               kFileVersionMS & 0xffff,
-                               kFileVersionLS >> 16,
-                               kFileVersionLS & 0xffff);
-  module_writer.SetProductVersion(kProductVersionMS >> 16,
-                                  kProductVersionMS & 0xffff,
-                                  kProductVersionLS >> 16,
-                                  kProductVersionLS & 0xffff);
-  module_writer.SetFileFlagsAndMask(kFileFlags, kFileFlagsMask);
-  module_writer.SetFileOS(kFileOS);
-  module_writer.SetFileTypeAndSubtype(kFileType, kFileSubtype);
+  auto module_writer = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer->SetName(kModuleName);
+  module_writer->SetImageBaseAddress(kModuleBase);
+  module_writer->SetImageSize(kModuleSize);
+  module_writer->SetChecksum(kChecksum);
+  module_writer->SetTimestamp(kTimestamp);
+  module_writer->SetFileVersion(kFileVersionMS >> 16,
+                                kFileVersionMS & 0xffff,
+                                kFileVersionLS >> 16,
+                                kFileVersionLS & 0xffff);
+  module_writer->SetProductVersion(kProductVersionMS >> 16,
+                                   kProductVersionMS & 0xffff,
+                                   kProductVersionLS >> 16,
+                                   kProductVersionLS & 0xffff);
+  module_writer->SetFileFlagsAndMask(kFileFlags, kFileFlagsMask);
+  module_writer->SetFileOS(kFileOS);
+  module_writer->SetFileTypeAndSubtype(kFileType, kFileSubtype);
 
-  MinidumpModuleCodeViewRecordPDB70Writer codeview_pdb70_writer;
-  codeview_pdb70_writer.SetPDBName(kPDBName);
-  codeview_pdb70_writer.SetUUIDAndAge(pdb_uuid, kPDBAge);
-  module_writer.SetCodeViewRecord(&codeview_pdb70_writer);
+  auto codeview_pdb70_writer =
+      make_scoped_ptr(new MinidumpModuleCodeViewRecordPDB70Writer());
+  codeview_pdb70_writer->SetPDBName(kPDBName);
+  codeview_pdb70_writer->SetUUIDAndAge(pdb_uuid, kPDBAge);
+  module_writer->SetCodeViewRecord(codeview_pdb70_writer.Pass());
 
-  MinidumpModuleMiscDebugRecordWriter misc_debug_writer;
-  misc_debug_writer.SetDataType(kDebugType);
-  misc_debug_writer.SetData(kDebugName, kDebugUTF16);
-  module_writer.SetMiscDebugRecord(&misc_debug_writer);
+  auto misc_debug_writer =
+      make_scoped_ptr(new MinidumpModuleMiscDebugRecordWriter());
+  misc_debug_writer->SetDataType(kDebugType);
+  misc_debug_writer->SetData(kDebugName, kDebugUTF16);
+  module_writer->SetMiscDebugRecord(misc_debug_writer.Pass());
 
-  module_list_writer.AddModule(&module_writer);
-  minidump_file_writer.AddStream(&module_list_writer);
+  module_list_writer->AddModule(module_writer.Pass());
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   ASSERT_GT(file_writer.string().size(),
             sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MODULE_LIST) + 1 * sizeof(MINIDUMP_MODULE));
 
   const MINIDUMP_MODULE_LIST* module_list;
   ASSERT_NO_FATAL_FAILURE(
@@ skipping 28 matching lines @@
                                        kDebugType,
                                        kDebugUTF16));
 }
 
 TEST(MinidumpModuleWriter, OneModule_CodeViewUsesPDB20_MiscUsesUTF16) {
   // MinidumpModuleWriter.OneModule tested with a PDB 7.0 link as the CodeView
   // record and an IMAGE_DEBUG_MISC record in UTF-8. This test exercises the
   // alternatives, a PDB 2.0 link as the CodeView record and an IMAGE_DEBUG_MISC
   // record with UTF-16 data.
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
 
   const char kModuleName[] = "dinosaur";
   const char kPDBName[] = "d1n05.pdb";
   const time_t kPDBTimestamp = 0x386d4380;
   const uint32_t kPDBAge = 1;
   const uint32_t kDebugType = IMAGE_DEBUG_MISC_EXENAME;
   const char kDebugName[] = "d1n05.dbg";
   const bool kDebugUTF16 = true;
 
-  MinidumpModuleWriter module_writer;
-  module_writer.SetName(kModuleName);
+  auto module_writer = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer->SetName(kModuleName);
 
-  MinidumpModuleCodeViewRecordPDB20Writer codeview_pdb20_writer;
-  codeview_pdb20_writer.SetPDBName(kPDBName);
-  codeview_pdb20_writer.SetTimestampAndAge(kPDBTimestamp, kPDBAge);
-  module_writer.SetCodeViewRecord(&codeview_pdb20_writer);
+  auto codeview_pdb20_writer =
+      make_scoped_ptr(new MinidumpModuleCodeViewRecordPDB20Writer());
+  codeview_pdb20_writer->SetPDBName(kPDBName);
+  codeview_pdb20_writer->SetTimestampAndAge(kPDBTimestamp, kPDBAge);
+  module_writer->SetCodeViewRecord(codeview_pdb20_writer.Pass());
 
-  MinidumpModuleMiscDebugRecordWriter misc_debug_writer;
-  misc_debug_writer.SetDataType(kDebugType);
-  misc_debug_writer.SetData(kDebugName, kDebugUTF16);
-  module_writer.SetMiscDebugRecord(&misc_debug_writer);
+  auto misc_debug_writer =
+      make_scoped_ptr(new MinidumpModuleMiscDebugRecordWriter());
+  misc_debug_writer->SetDataType(kDebugType);
+  misc_debug_writer->SetData(kDebugName, kDebugUTF16);
+  module_writer->SetMiscDebugRecord(misc_debug_writer.Pass());
 
-  module_list_writer.AddModule(&module_writer);
-  minidump_file_writer.AddStream(&module_list_writer);
+  module_list_writer->AddModule(module_writer.Pass());
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   ASSERT_GT(file_writer.string().size(),
             sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MODULE_LIST) + 1 * sizeof(MINIDUMP_MODULE));
 
   const MINIDUMP_MODULE_LIST* module_list;
   ASSERT_NO_FATAL_FAILURE(
@@ skipping 14 matching lines @@
                                        kDebugName,
                                        kDebugType,
                                        kDebugUTF16));
 }
 
 TEST(MinidumpModuleWriter, ThreeModules) {
   // As good exercise, this test uses three modules, one with a PDB 7.0 link as
   // its CodeView record, one with no CodeView record, and one with a PDB 2.0
   // link as its CodeView record.
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
 
   const char kModuleName0[] = "main";
   const uint64_t kModuleBase0 = 0x100101000;
   const uint32_t kModuleSize0 = 0xf000;
   const char kPDBName0[] = "main";
   const uint8_t kPDBUUIDBytes0[16] =
       {0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff, 0x00, 0x11,
        0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88, 0x99};
   UUID pdb_uuid_0;
   pdb_uuid_0.InitializeFromBytes(kPDBUUIDBytes0);
   const uint32_t kPDBAge0 = 0;
 
   const char kModuleName1[] = "ld.so";
   const uint64_t kModuleBase1 = 0x200202000;
   const uint32_t kModuleSize1 = 0x1e000;
 
   const char kModuleName2[] = "libc.so";
   const uint64_t kModuleBase2 = 0x300303000;
   const uint32_t kModuleSize2 = 0x2d000;
   const char kPDBName2[] = "libc.so";
   const time_t kPDBTimestamp2 = 0x386d4380;
   const uint32_t kPDBAge2 = 2;
 
-  MinidumpModuleWriter module_writer_0;
-  module_writer_0.SetName(kModuleName0);
-  module_writer_0.SetImageBaseAddress(kModuleBase0);
-  module_writer_0.SetImageSize(kModuleSize0);
+  auto module_writer_0 = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer_0->SetName(kModuleName0);
+  module_writer_0->SetImageBaseAddress(kModuleBase0);
+  module_writer_0->SetImageSize(kModuleSize0);
 
-  MinidumpModuleCodeViewRecordPDB70Writer codeview_pdb70_writer_0;
-  codeview_pdb70_writer_0.SetPDBName(kPDBName0);
-  codeview_pdb70_writer_0.SetUUIDAndAge(pdb_uuid_0, kPDBAge0);
-  module_writer_0.SetCodeViewRecord(&codeview_pdb70_writer_0);
+  auto codeview_pdb70_writer_0 =
+      make_scoped_ptr(new MinidumpModuleCodeViewRecordPDB70Writer());
+  codeview_pdb70_writer_0->SetPDBName(kPDBName0);
+  codeview_pdb70_writer_0->SetUUIDAndAge(pdb_uuid_0, kPDBAge0);
+  module_writer_0->SetCodeViewRecord(codeview_pdb70_writer_0.Pass());
 
-  module_list_writer.AddModule(&module_writer_0);
+  module_list_writer->AddModule(module_writer_0.Pass());
 
-  MinidumpModuleWriter module_writer_1;
-  module_writer_1.SetName(kModuleName1);
-  module_writer_1.SetImageBaseAddress(kModuleBase1);
-  module_writer_1.SetImageSize(kModuleSize1);
+  auto module_writer_1 = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer_1->SetName(kModuleName1);
+  module_writer_1->SetImageBaseAddress(kModuleBase1);
+  module_writer_1->SetImageSize(kModuleSize1);
 
-  module_list_writer.AddModule(&module_writer_1);
+  module_list_writer->AddModule(module_writer_1.Pass());
 
-  MinidumpModuleWriter module_writer_2;
-  module_writer_2.SetName(kModuleName2);
-  module_writer_2.SetImageBaseAddress(kModuleBase2);
-  module_writer_2.SetImageSize(kModuleSize2);
+  auto module_writer_2 = make_scoped_ptr(new MinidumpModuleWriter());
+  module_writer_2->SetName(kModuleName2);
+  module_writer_2->SetImageBaseAddress(kModuleBase2);
+  module_writer_2->SetImageSize(kModuleSize2);
 
-  MinidumpModuleCodeViewRecordPDB20Writer codeview_pdb70_writer_2;
-  codeview_pdb70_writer_2.SetPDBName(kPDBName2);
-  codeview_pdb70_writer_2.SetTimestampAndAge(kPDBTimestamp2, kPDBAge2);
-  module_writer_2.SetCodeViewRecord(&codeview_pdb70_writer_2);
+  auto codeview_pdb70_writer_2 =
+      make_scoped_ptr(new MinidumpModuleCodeViewRecordPDB20Writer());
+  codeview_pdb70_writer_2->SetPDBName(kPDBName2);
+  codeview_pdb70_writer_2->SetTimestampAndAge(kPDBTimestamp2, kPDBAge2);
+  module_writer_2->SetCodeViewRecord(codeview_pdb70_writer_2.Pass());
 
-  module_list_writer.AddModule(&module_writer_2);
+  module_list_writer->AddModule(module_writer_2.Pass());
 
-  minidump_file_writer.AddStream(&module_list_writer);
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   ASSERT_GT(file_writer.string().size(),
             sizeof(MINIDUMP_HEADER) + sizeof(MINIDUMP_DIRECTORY) +
                 sizeof(MINIDUMP_MODULE_LIST) + 1 * sizeof(MINIDUMP_MODULE));
 
   const MINIDUMP_MODULE_LIST* module_list;
   ASSERT_NO_FATAL_FAILURE(
@@ skipping 56 matching lines @@
                                          kPDBTimestamp2,
                                          kPDBAge2,
                                          nullptr,
                                          0,
                                          false));
   }
 }
 
 TEST(MinidumpSystemInfoWriterDeathTest, NoModuleName) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpModuleListWriter module_list_writer;
-  MinidumpModuleWriter module_writer;
-  module_list_writer.AddModule(&module_writer);
-  minidump_file_writer.AddStream(&module_list_writer);
+  auto module_list_writer = make_scoped_ptr(new MinidumpModuleListWriter());
+  auto module_writer = make_scoped_ptr(new MinidumpModuleWriter());
+  module_list_writer->AddModule(module_writer.Pass());
+  minidump_file_writer.AddStream(module_list_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "name_");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad