minidump: Change the ownership model

minidump/minidump_misc_info_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "minidump/minidump_misc_info_writer.h"
 
 #include <dbghelp.h>
 #include <string.h>
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "gtest/gtest.h"
 #include "minidump/minidump_file_writer.h"
 #include "minidump/test/minidump_file_writer_test_util.h"
 #include "minidump/test/minidump_writable_test_util.h"
 #include "util/file/string_file_writer.h"
 #include "util/stdlib/strlcpy.h"
 
 namespace crashpad {
@@ skipping 115 matching lines @@
   {
     SCOPED_TRACE("DbgBldStr");
     ExpectNULPaddedString16Equal(expected->DbgBldStr,
                                  observed->DbgBldStr,
                                  arraysize(expected->DbgBldStr));
   }
 }
 
 TEST(MinidumpMiscInfoWriter, Empty) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessId) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessId = 12345;
 
-  misc_info_writer.SetProcessId(kProcessId);
+  misc_info_writer->SetProcessId(kProcessId);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESS_ID;
   expected.ProcessId = kProcessId;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessTimes) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const time_t kProcessCreateTime = 0x15252f00;
   const uint32_t kProcessUserTime = 10;
   const uint32_t kProcessKernelTime = 5;
 
-  misc_info_writer.SetProcessTimes(
+  misc_info_writer->SetProcessTimes(
       kProcessCreateTime, kProcessUserTime, kProcessKernelTime);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESS_TIMES;
   expected.ProcessCreateTime = kProcessCreateTime;
   expected.ProcessUserTime = kProcessUserTime;
   expected.ProcessKernelTime = kProcessKernelTime;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessorPowerInfo) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessorMaxMhz = 2800;
   const uint32_t kProcessorCurrentMhz = 2300;
   const uint32_t kProcessorMhzLimit = 3300;
   const uint32_t kProcessorMaxIdleState = 5;
   const uint32_t kProcessorCurrentIdleState = 1;
 
-  misc_info_writer.SetProcessorPowerInfo(kProcessorMaxMhz,
-                                         kProcessorCurrentMhz,
-                                         kProcessorMhzLimit,
-                                         kProcessorMaxIdleState,
-                                         kProcessorCurrentIdleState);
+  misc_info_writer->SetProcessorPowerInfo(kProcessorMaxMhz,
+                                          kProcessorCurrentMhz,
+                                          kProcessorMhzLimit,
+                                          kProcessorMaxIdleState,
+                                          kProcessorCurrentIdleState);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_2* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_2 expected = {};
   expected.Flags1 = MINIDUMP_MISC1_PROCESSOR_POWER_INFO;
   expected.ProcessorMaxMhz = kProcessorMaxMhz;
   expected.ProcessorCurrentMhz = kProcessorCurrentMhz;
   expected.ProcessorMhzLimit = kProcessorMhzLimit;
   expected.ProcessorMaxIdleState = kProcessorMaxIdleState;
   expected.ProcessorCurrentIdleState = kProcessorCurrentIdleState;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessIntegrityLevel) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessIntegrityLevel = 0x2000;
 
-  misc_info_writer.SetProcessIntegrityLevel(kProcessIntegrityLevel);
+  misc_info_writer->SetProcessIntegrityLevel(kProcessIntegrityLevel);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_3* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROCESS_INTEGRITY;
   expected.ProcessIntegrityLevel = kProcessIntegrityLevel;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProcessExecuteFlags) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessExecuteFlags = 0x13579bdf;
 
-  misc_info_writer.SetProcessExecuteFlags(kProcessExecuteFlags);
+  misc_info_writer->SetProcessExecuteFlags(kProcessExecuteFlags);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_3* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROCESS_EXECUTE_FLAGS;
   expected.ProcessExecuteFlags = kProcessExecuteFlags;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, ProtectedProcess) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProtectedProcess = 1;
 
-  misc_info_writer.SetProtectedProcess(kProtectedProcess);
+  misc_info_writer->SetProtectedProcess(kProtectedProcess);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_3* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_PROTECTED_PROCESS;
   expected.ProtectedProcess = kProtectedProcess;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, TimeZone) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kTimeZoneId = 2;
   const int32_t kBias = 300;
   const char kStandardName[] = "EST";
   const SYSTEMTIME kStandardDate = {0, 11, 1, 0, 2, 0, 0, 0};
   const int32_t kStandardBias = 0;
   const char kDaylightName[] = "EDT";
   const SYSTEMTIME kDaylightDate = {0, 3, 2, 0, 2, 0, 0, 0};
   const int32_t kDaylightBias = -60;
 
-  misc_info_writer.SetTimeZone(kTimeZoneId,
-                               kBias,
-                               kStandardName,
-                               kStandardDate,
-                               kStandardBias,
-                               kDaylightName,
-                               kDaylightDate,
-                               kDaylightBias);
+  misc_info_writer->SetTimeZone(kTimeZoneId,
+                                kBias,
+                                kStandardName,
+                                kStandardDate,
+                                kStandardBias,
+                                kDaylightName,
+                                kDaylightDate,
+                                kDaylightBias);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_3* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_TIMEZONE;
   expected.TimeZoneId = kTimeZoneId;
@@ skipping 16 matching lines @@
   expected.TimeZone.DaylightBias = kDaylightBias;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, TimeZoneStringsOverflow) {
   // This test makes sure that the time zone name strings are truncated properly
   // to the widths of their fields.
 
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kTimeZoneId = 2;
   const int32_t kBias = 300;
   std::string standard_name(
       arraysize(decltype(MINIDUMP_MISC_INFO_N::TimeZone)::StandardName) + 1,
       's');
   const int32_t kStandardBias = 0;
   std::string daylight_name(
       arraysize(decltype(MINIDUMP_MISC_INFO_N::TimeZone)::DaylightName), 'd');
   const int32_t kDaylightBias = -60;
 
   // Test using kSystemTimeZero, because not all platforms will be able to
   // provide daylight saving time transition times.
   const SYSTEMTIME kSystemTimeZero = {};
 
-  misc_info_writer.SetTimeZone(kTimeZoneId,
-                               kBias,
-                               standard_name,
-                               kSystemTimeZero,
-                               kStandardBias,
-                               daylight_name,
-                               kSystemTimeZero,
-                               kDaylightBias);
+  misc_info_writer->SetTimeZone(kTimeZoneId,
+                                kBias,
+                                standard_name,
+                                kSystemTimeZero,
+                                kStandardBias,
+                                daylight_name,
+                                kSystemTimeZero,
+                                kDaylightBias);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_3* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_3 expected = {};
   expected.Flags1 = MINIDUMP_MISC3_TIMEZONE;
   expected.TimeZoneId = kTimeZoneId;
@@ skipping 13 matching lines @@
   memcpy(&expected.TimeZone.DaylightDate,
          &kSystemTimeZero,
          sizeof(expected.TimeZone.DaylightDate));
   expected.TimeZone.DaylightBias = kDaylightBias;
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, BuildStrings) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const char kBuildString[] = "build string";
   const char kDebugBuildString[] = "debug build string";
 
-  misc_info_writer.SetBuildString(kBuildString, kDebugBuildString);
+  misc_info_writer->SetBuildString(kBuildString, kDebugBuildString);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_4* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 = MINIDUMP_MISC4_BUILDSTRING;
   string16 build_string_utf16 = base::UTF8ToUTF16(kBuildString);
   c16lcpy(expected.BuildString,
           build_string_utf16.c_str(),
           arraysize(expected.BuildString));
   string16 debug_build_string_utf16 = base::UTF8ToUTF16(kDebugBuildString);
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
           arraysize(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, BuildStringsOverflow) {
   // This test makes sure that the build strings are truncated properly to the
   // widths of their fields.
 
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   std::string build_string(arraysize(MINIDUMP_MISC_INFO_N::BuildString) + 1,
                            'B');
   std::string debug_build_string(arraysize(MINIDUMP_MISC_INFO_N::DbgBldStr),
                                  'D');
 
-  misc_info_writer.SetBuildString(build_string, debug_build_string);
+  misc_info_writer->SetBuildString(build_string, debug_build_string);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_4* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 = MINIDUMP_MISC4_BUILDSTRING;
   string16 build_string_utf16 = base::UTF8ToUTF16(build_string);
   c16lcpy(expected.BuildString,
           build_string_utf16.c_str(),
           arraysize(expected.BuildString));
   string16 debug_build_string_utf16 = base::UTF8ToUTF16(debug_build_string);
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
           arraysize(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 TEST(MinidumpMiscInfoWriter, Everything) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpMiscInfoWriter misc_info_writer;
+  auto misc_info_writer = make_scoped_ptr(new MinidumpMiscInfoWriter());
 
   const uint32_t kProcessId = 12345;
   const time_t kProcessCreateTime = 0x15252f00;
   const uint32_t kProcessUserTime = 10;
   const uint32_t kProcessKernelTime = 5;
   const uint32_t kProcessorMaxMhz = 2800;
   const uint32_t kProcessorCurrentMhz = 2300;
   const uint32_t kProcessorMhzLimit = 3300;
   const uint32_t kProcessorMaxIdleState = 5;
   const uint32_t kProcessorCurrentIdleState = 1;
   const uint32_t kProcessIntegrityLevel = 0x2000;
   const uint32_t kProcessExecuteFlags = 0x13579bdf;
   const uint32_t kProtectedProcess = 1;
   const uint32_t kTimeZoneId = 2;
   const int32_t kBias = 300;
   const char kStandardName[] = "EST";
   const int32_t kStandardBias = 0;
   const char kDaylightName[] = "EDT";
   const int32_t kDaylightBias = -60;
   const SYSTEMTIME kSystemTimeZero = {};
   const char kBuildString[] = "build string";
   const char kDebugBuildString[] = "debug build string";
 
-  misc_info_writer.SetProcessId(kProcessId);
-  misc_info_writer.SetProcessTimes(
+  misc_info_writer->SetProcessId(kProcessId);
+  misc_info_writer->SetProcessTimes(
       kProcessCreateTime, kProcessUserTime, kProcessKernelTime);
-  misc_info_writer.SetProcessorPowerInfo(kProcessorMaxMhz,
-                                         kProcessorCurrentMhz,
-                                         kProcessorMhzLimit,
-                                         kProcessorMaxIdleState,
-                                         kProcessorCurrentIdleState);
-  misc_info_writer.SetProcessIntegrityLevel(kProcessIntegrityLevel);
-  misc_info_writer.SetProcessExecuteFlags(kProcessExecuteFlags);
-  misc_info_writer.SetProtectedProcess(kProtectedProcess);
-  misc_info_writer.SetTimeZone(kTimeZoneId,
-                               kBias,
-                               kStandardName,
-                               kSystemTimeZero,
-                               kStandardBias,
-                               kDaylightName,
-                               kSystemTimeZero,
-                               kDaylightBias);
-  misc_info_writer.SetBuildString(kBuildString, kDebugBuildString);
+  misc_info_writer->SetProcessorPowerInfo(kProcessorMaxMhz,
+                                          kProcessorCurrentMhz,
+                                          kProcessorMhzLimit,
+                                          kProcessorMaxIdleState,
+                                          kProcessorCurrentIdleState);
+  misc_info_writer->SetProcessIntegrityLevel(kProcessIntegrityLevel);
+  misc_info_writer->SetProcessExecuteFlags(kProcessExecuteFlags);
+  misc_info_writer->SetProtectedProcess(kProtectedProcess);
+  misc_info_writer->SetTimeZone(kTimeZoneId,
+                                kBias,
+                                kStandardName,
+                                kSystemTimeZero,
+                                kStandardBias,
+                                kDaylightName,
+                                kSystemTimeZero,
+                                kDaylightBias);
+  misc_info_writer->SetBuildString(kBuildString, kDebugBuildString);
 
-  minidump_file_writer.AddStream(&misc_info_writer);
+  minidump_file_writer.AddStream(misc_info_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_MISC_INFO_4* observed;
   ASSERT_NO_FATAL_FAILURE(GetMiscInfoStream(file_writer.string(), &observed));
 
   MINIDUMP_MISC_INFO_4 expected = {};
   expected.Flags1 =
       MINIDUMP_MISC1_PROCESS_ID | MINIDUMP_MISC1_PROCESS_TIMES |
@@ skipping 38 matching lines @@
   c16lcpy(expected.DbgBldStr,
           debug_build_string_utf16.c_str(),
           arraysize(expected.DbgBldStr));
 
   ExpectMiscInfoEqual(&expected, observed);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad