minidump: Change the ownership model

minidump/minidump_exception_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 75 matching lines @@
     EXPECT_EQ(expected->ExceptionRecord.ExceptionInformation[index],
               observed->ExceptionRecord.ExceptionInformation[index]);
   }
   *context = MinidumpWritableAtLocationDescriptor<MinidumpContextX86>(
       file_contents, observed->ThreadContext);
   ASSERT_TRUE(context);
 }
 
 TEST(MinidumpExceptionWriter, Minimal) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpExceptionWriter exception_writer;
+  auto exception_writer = make_scoped_ptr(new MinidumpExceptionWriter());
 
   const uint32_t kSeed = 100;
 
-  MinidumpContextX86Writer context_x86_writer;
-  InitializeMinidumpContextX86(context_x86_writer.context(), kSeed);
-  exception_writer.SetContext(&context_x86_writer);
+  auto context_x86_writer = make_scoped_ptr(new MinidumpContextX86Writer());
+  InitializeMinidumpContextX86(context_x86_writer->context(), kSeed);
+  exception_writer->SetContext(context_x86_writer.Pass());
 
-  minidump_file_writer.AddStream(&exception_writer);
+  minidump_file_writer.AddStream(exception_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream;
   ASSERT_NO_FATAL_FAILURE(
       GetExceptionStream(file_writer.string(), &observed_exception_stream));
 
   MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {};
   expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86);
 
   const MinidumpContextX86* observed_context;
   ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream,
                                                 observed_exception_stream,
                                                 file_writer.string(),
                                                 &observed_context));
 
   ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed, observed_context));
 }
 
 TEST(MinidumpExceptionWriter, Standard) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpExceptionWriter exception_writer;
+  auto exception_writer = make_scoped_ptr(new MinidumpExceptionWriter());
 
   const uint32_t kSeed = 200;
   const uint32_t kThreadID = 1;
   const uint32_t kExceptionCode = 2;
   const uint32_t kExceptionFlags = 3;
   const uint32_t kExceptionRecord = 4;
   const uint32_t kExceptionAddress = 5;
   const uint64_t kExceptionInformation0 = 6;
   const uint64_t kExceptionInformation1 = 7;
   const uint64_t kExceptionInformation2 = 7;
 
-  MinidumpContextX86Writer context_x86_writer;
-  InitializeMinidumpContextX86(context_x86_writer.context(), kSeed);
-  exception_writer.SetContext(&context_x86_writer);
+  auto context_x86_writer = make_scoped_ptr(new MinidumpContextX86Writer());
+  InitializeMinidumpContextX86(context_x86_writer->context(), kSeed);
+  exception_writer->SetContext(context_x86_writer.Pass());
 
-  exception_writer.SetThreadID(kThreadID);
-  exception_writer.SetExceptionCode(kExceptionCode);
-  exception_writer.SetExceptionFlags(kExceptionFlags);
-  exception_writer.SetExceptionRecord(kExceptionRecord);
-  exception_writer.SetExceptionAddress(kExceptionAddress);
+  exception_writer->SetThreadID(kThreadID);
+  exception_writer->SetExceptionCode(kExceptionCode);
+  exception_writer->SetExceptionFlags(kExceptionFlags);
+  exception_writer->SetExceptionRecord(kExceptionRecord);
+  exception_writer->SetExceptionAddress(kExceptionAddress);
 
   // Set a lot of exception information at first, and then replace it with less.
   // This tests that the exception that is written does not contain the
   // “garbage” from the initial SetExceptionInformation() call.
   std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS,
                                               0x5a5a5a5a5a5a5a5a);
-  exception_writer.SetExceptionInformation(exception_information);
+  exception_writer->SetExceptionInformation(exception_information);
 
   exception_information.clear();
   exception_information.push_back(kExceptionInformation0);
   exception_information.push_back(kExceptionInformation1);
   exception_information.push_back(kExceptionInformation2);
-  exception_writer.SetExceptionInformation(exception_information);
+  exception_writer->SetExceptionInformation(exception_information);
 
-  minidump_file_writer.AddStream(&exception_writer);
+  minidump_file_writer.AddStream(exception_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
 
   const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream;
   ASSERT_NO_FATAL_FAILURE(
       GetExceptionStream(file_writer.string(), &observed_exception_stream));
 
   MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {};
   expected_exception_stream.ThreadId = kThreadID;
@@ skipping 14 matching lines @@
   ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream,
                                                 observed_exception_stream,
                                                 file_writer.string(),
                                                 &observed_context));
 
   ASSERT_NO_FATAL_FAILURE(ExpectMinidumpContextX86(kSeed, observed_context));
 }
 
 TEST(MinidumpExceptionWriterDeathTest, NoContext) {
   MinidumpFileWriter minidump_file_writer;
-  MinidumpExceptionWriter exception_writer;
+  auto exception_writer = make_scoped_ptr(new MinidumpExceptionWriter());
 
-  minidump_file_writer.AddStream(&exception_writer);
+  minidump_file_writer.AddStream(exception_writer.Pass());
 
   StringFileWriter file_writer;
   ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), "context_");
 }
 
 TEST(MinidumpExceptionWriterDeathTest, TooMuchInformation) {
   MinidumpExceptionWriter exception_writer;
   std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS + 1,
                                               0x5a5a5a5a5a5a5a5a);
   ASSERT_DEATH(exception_writer.SetExceptionInformation(exception_information),
                "kMaxParameters");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad