Reland: Script streaming: Add an option to make the main thread block (wait for parsing)

Reland 2: Script streaming: Add an option to make the main thread block (wait for parsing)

This is the same as r184361 which was speculatively reverted (since the earlier
version of it was broken).

This makes the main thread block and wait for the parser thread when all the
script data has arrived. The goal is to ensure that the script (which can now be
compiled) will get the main thread's attention as soon as possible.

This feature is temporary: The usefulness of blocking will be evaluated with
Finch, and this option will be removed (blocking will be always enabled or never
enabled, based on which option turns out to be better).

Previous (broken) version: https://codereview.chromium.org/651163002/

R=haraken@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184504

[marja, 2014-10-24 13:05:52]

haraken, ptal.

The first patch set is what I landed before, and fixes are in a separate patch
set.

Main fixes: 1) keepAlive fix 2) when suppressing,
streamingCompleteOnBackgroundThread can happen before notifyFinished.

[Sami, 2014-10-24 13:23:20]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2014-10-24 13:23:21]

Condition var usage lgtm now, thanks!

[haraken, 2014-10-24 13:43:04]

LGTM

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptStreamer.cpp (right):

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:339: ASSERT(isFinished());

This ASSERT won't make sense.

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:344: RefPtr<ScriptStreamer>
keepAlive(this);

Nit: We normally use 'protect'.

[marja, 2014-10-24 13:48:23]

thx for review

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptStreamer.cpp (right):

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:339: ASSERT(isFinished());
On 2014/10/24 13:43:04, haraken wrote:
> 
> This ASSERT won't make sense.

Done.

https://codereview.chromium.org/674133002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:344: RefPtr<ScriptStreamer>
keepAlive(this);
On 2014/10/24 13:43:04, haraken wrote:
> 
> Nit: We normally use 'protect'.

Done.

[marja, 2014-10-24 13:48:27]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-10-24 13:49:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674133002/60001

[commit-bot: I haz the power, 2014-10-24 14:53:23]

Committed patchset #4 (id:60001) as 184361

[marja, 2014-10-28 09:53:45]

This got reverted because of crashes, but the crash interval actually contains
the earlier version of the new commit. There's no data whether the new version
ever contributed to crashes. So I'm going to reopen this CL and land this again
as is.

[marja, 2014-10-28 09:55:39]

The CQ bit was checked by marja@chromium.org

[marja, 2014-10-28 09:56:12]

(See crbug.com/426957)

[commit-bot: I haz the power, 2014-10-28 09:56:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674133002/60001

[commit-bot: I haz the power, 2014-10-28 09:57:23]

Committed patchset #4 (id:60001) as 184504

[marja, 2014-10-28 09:59:10]

Wut, the commit bot didn't run any try jobs... that was not intentional. o.O