Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: cc/resources/eviction_tile_priority_queue.cc

Issue 674103004: [WIP] cc: Use reverse spiral iterator in tiling eviction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/eviction_tile_priority_queue.h ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/eviction_tile_priority_queue.h" 5 #include "cc/resources/eviction_tile_priority_queue.h"
6 6
7 namespace cc { 7 namespace cc {
8 8
9 namespace { 9 namespace {
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 Tile* EvictionTilePriorityQueue::PairedPictureLayerQueue::Top( 150 Tile* EvictionTilePriorityQueue::PairedPictureLayerQueue::Top(
151 TreePriority tree_priority) { 151 TreePriority tree_priority) {
152 DCHECK(!IsEmpty()); 152 DCHECK(!IsEmpty());
153 153
154 WhichTree next_tree = NextTileIteratorTree(tree_priority); 154 WhichTree next_tree = NextTileIteratorTree(tree_priority);
155 PictureLayerImpl::LayerEvictionTileIterator* next_iterator = 155 PictureLayerImpl::LayerEvictionTileIterator* next_iterator =
156 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator; 156 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator;
157 DCHECK(*next_iterator); 157 DCHECK(*next_iterator);
158 158
159 Tile* tile = **next_iterator; 159 Tile* tile = **next_iterator;
160 DCHECK(std::find(returned_shared_tiles.begin(), 160 DCHECK(returned_tiles_for_debug.find(tile) == returned_tiles_for_debug.end());
161 returned_shared_tiles.end(),
162 tile) == returned_shared_tiles.end());
163 return tile; 161 return tile;
164 } 162 }
165 163
166 void EvictionTilePriorityQueue::PairedPictureLayerQueue::Pop( 164 void EvictionTilePriorityQueue::PairedPictureLayerQueue::Pop(
167 TreePriority tree_priority) { 165 TreePriority tree_priority) {
168 DCHECK(!IsEmpty()); 166 DCHECK(!IsEmpty());
169 167
170 WhichTree next_tree = NextTileIteratorTree(tree_priority); 168 WhichTree next_tree = NextTileIteratorTree(tree_priority);
171 PictureLayerImpl::LayerEvictionTileIterator* next_iterator = 169 PictureLayerImpl::LayerEvictionTileIterator* next_iterator =
172 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator; 170 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator;
173 DCHECK(*next_iterator); 171 DCHECK(*next_iterator);
174 returned_shared_tiles.push_back(**next_iterator); 172 DCHECK(returned_tiles_for_debug.insert(**next_iterator).second);
175 ++(*next_iterator); 173 ++(*next_iterator);
176 174
177 if (IsEmpty()) 175 // If no empty, use Top to do DCHECK the next iterator.
178 return; 176 DCHECK(IsEmpty() || Top(tree_priority));
179
180 next_tree = NextTileIteratorTree(tree_priority);
181 next_iterator =
182 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator;
183 while (std::find(returned_shared_tiles.begin(),
184 returned_shared_tiles.end(),
185 **next_iterator) != returned_shared_tiles.end()) {
186 ++(*next_iterator);
187 if (IsEmpty())
188 break;
189 next_tree = NextTileIteratorTree(tree_priority);
190 next_iterator =
191 next_tree == ACTIVE_TREE ? &active_iterator : &pending_iterator;
192 }
193 } 177 }
194 178
195 WhichTree 179 WhichTree
196 EvictionTilePriorityQueue::PairedPictureLayerQueue::NextTileIteratorTree( 180 EvictionTilePriorityQueue::PairedPictureLayerQueue::NextTileIteratorTree(
197 TreePriority tree_priority) const { 181 TreePriority tree_priority) const {
198 DCHECK(!IsEmpty()); 182 DCHECK(!IsEmpty());
199 183
200 // If we only have one iterator with tiles, return it. 184 // If we only have one iterator with tiles, return it.
201 if (!active_iterator) 185 if (!active_iterator)
202 return PENDING_TREE; 186 return PENDING_TREE;
203 if (!pending_iterator) 187 if (!pending_iterator)
204 return ACTIVE_TREE; 188 return ACTIVE_TREE;
205 189
206 const Tile* active_tile = *active_iterator; 190 const Tile* active_tile = *active_iterator;
207 const Tile* pending_tile = *pending_iterator; 191 const Tile* pending_tile = *pending_iterator;
208 if (active_tile == pending_tile) 192 if (active_tile == pending_tile)
209 return ACTIVE_TREE; 193 return ACTIVE_TREE;
210 194
211 const TilePriority& active_priority = 195 const TilePriority& active_priority =
212 active_tile->priority_for_tree_priority(tree_priority); 196 active_tile->priority_for_tree_priority(tree_priority);
213 const TilePriority& pending_priority = 197 const TilePriority& pending_priority =
214 pending_tile->priority_for_tree_priority(tree_priority); 198 pending_tile->priority_for_tree_priority(tree_priority);
215 199
200 if (active_priority.priority_bin == pending_priority.priority_bin) {
201 if (active_tile->required_for_activation()) {
202 if (!pending_tile->required_for_activation())
203 return PENDING_TREE;
204 } else if (pending_tile->required_for_activation()) {
205 return ACTIVE_TREE;
206 }
207 }
208
216 if (pending_priority.IsHigherPriorityThan(active_priority)) 209 if (pending_priority.IsHigherPriorityThan(active_priority))
217 return ACTIVE_TREE; 210 return ACTIVE_TREE;
218 return PENDING_TREE; 211 return PENDING_TREE;
219 } 212 }
220 213
221 } // namespace cc 214 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/eviction_tile_priority_queue.h ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698