Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 674103003: Ignore internal_gyp. (Closed)

Created:
6 years, 2 months ago by grt (UTC plus 2)
Modified:
6 years, 1 month ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ignore internal_gyp. BUG=412884 R=bengr@chromium.org Committed: https://crrev.com/3f78e2ab228ce763403a6e92cc08e240b0305633 Cr-Commit-Position: refs/heads/master@{#301554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
grt (UTC plus 2)
I can't upload due to this new internal dep: Cannot upload with a dirty tree. ...
6 years, 2 months ago (2014-10-24 15:48:49 UTC) #1
bengr
lgtm
6 years, 1 month ago (2014-10-27 21:48:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674103003/1
6 years, 1 month ago (2014-10-28 01:51:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 02:30:00 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 02:30:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f78e2ab228ce763403a6e92cc08e240b0305633
Cr-Commit-Position: refs/heads/master@{#301554}

Powered by Google App Engine
This is Rietveld 408576698