Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 674083002: Revert of Specifies transparent background for the label in TileItemView. (Closed)

Created:
6 years, 2 months ago by kjellander_chromium
Modified:
6 years, 2 months ago
Reviewers:
xiyuan, Jun Mukai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, tapted, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Specifies transparent background for the label in TileItemView. (patchset #2 id:10002 of https://codereview.chromium.org/655823005/) Reason for revert: Introduces static initializer, see https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/72389 Original issue's description: > Specifies transparent background for the label in TileItemView. > > We may not use single background when it's in Athena (it's not > used yet though). > > BUG=425717 > R=xiyuan@chromium.org > TEST=manually > > Committed: https://crrev.com/3b74c2c950e3681a94601f61d48a6ff0e25f06f8 > Cr-Commit-Position: refs/heads/master@{#301007} TBR=xiyuan@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=425717 Committed: https://crrev.com/0d84d44973229737ab2d5350d81311d58d58d581 Cr-Commit-Position: refs/heads/master@{#301066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M ui/app_list/views/tile_item_view.cc View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kjellander_chromium
Created Revert of Specifies transparent background for the label in TileItemView.
6 years, 2 months ago (2014-10-24 06:16:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674083002/1
6 years, 2 months ago (2014-10-24 06:17:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 06:17:46 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d84d44973229737ab2d5350d81311d58d58d581 Cr-Commit-Position: refs/heads/master@{#301066}
6 years, 2 months ago (2014-10-24 06:18:24 UTC) #4
Jun Mukai
On 2014/10/24 06:18:24, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-10-24 08:18:12 UTC) #5
kjellander_chromium
On 2014/10/24 08:18:12, Jun Mukai wrote: > On 2014/10/24 06:18:24, I haz the power (commit-bot) ...
6 years, 2 months ago (2014-10-24 08:32:22 UTC) #6
Jun Mukai
On 2014/10/24 08:32:22, kjellander wrote: > On 2014/10/24 08:18:12, Jun Mukai wrote: > > On ...
6 years, 2 months ago (2014-10-24 17:10:30 UTC) #7
Jun Mukai
6 years, 2 months ago (2014-10-24 17:55:35 UTC) #8
Message was sent while issue was closed.
On 2014/10/24 17:10:30, Jun Mukai wrote:
> On 2014/10/24 08:32:22, kjellander wrote:
> > On 2014/10/24 08:18:12, Jun Mukai wrote:
> > > On 2014/10/24 06:18:24, I haz the power (commit-bot) wrote:
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/0d84d44973229737ab2d5350d81311d58d58d581
> > > > Cr-Commit-Position: refs/heads/master@{#301066}
> > > 
> > > SkColor is an int. How does this increases static initializer that big?
> > 
> > I don't know, something related to the include of
> > "ui/base/resource/resource_bundle.h" ?
> > It solved the size regression at least, so the revert was valid.
> 
> resource_bundle.h was included implicitly by another header. I added that line
> to express the dependency explicitly.
> But okay, I'll retry that without that inclusion.

Ah, I was wrong. I found why my CL was bad.  I'll address the issue and try
reland. thanks.

Powered by Google App Engine
This is Rietveld 408576698