Issue 674073005: Remove final instances of WritingMode in Sky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 674073005: Remove final instances of WritingMode in Sky. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
mojo-reviews_chromium.org, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove final instances of WritingMode in Sky. After this patch, the only instance of WritingMode is in a comment. No change in behavior. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5fbf94978767669f49ca05af2a19442fb708d20e

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -36 lines)			Patch
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp	View	3 chunks	+6 lines, -18 lines	0 comments	Download

Total messages: 1 (0 generated)

ojan

6 years, 1 month ago (2014-10-30 02:58:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5fbf94978767669f49ca05af2a19442fb708d20e.