Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 674073004: X87: EmitCreateIteratorResult loads map from function's context (Closed)

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years, 1 month ago
Reviewers:
Weiliang, wingo
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: EmitCreateIteratorResult loads map from function's context port r24987 original commit message: EmitCreateIteratorResult loads map from function's context Caching or serialization can cause full-codegen output to be shared between contexts. CreateIteratorResult, however, was doing the wrong thing by creating results with the map that was current when the code was generated. Instead, we should chase pointers to load the right map from the function's context. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL. PTAL. thanks
6 years, 1 month ago (2014-10-30 02:17:36 UTC) #2
Weiliang
lgtm
6 years, 1 month ago (2014-10-30 03:41:32 UTC) #3
Weiliang
6 years, 1 month ago (2014-10-30 03:49:57 UTC) #4
Committed as r25000

Powered by Google App Engine
This is Rietveld 408576698