Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: content/common/plugin_list_win.cc

Issue 674073003: Only scan for correct architecture plugin binaries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/plugin_list_win.cc
diff --git a/content/common/plugin_list_win.cc b/content/common/plugin_list_win.cc
index f58a167696533fbe12e5b2d87e7bfa77535a464f..ccc994b8f5563f65c46873e52433825cf7275970 100644
--- a/content/common/plugin_list_win.cc
+++ b/content/common/plugin_list_win.cc
@@ -362,17 +362,15 @@ void PluginList::GetPluginPathsFromRegistry(
std::set<base::FilePath> plugin_dirs;
+ // Search for plugins from HKCU and HKLM. THis will only find plugins that
+ // are correctly registered in the correct WOW64 registry hive.
GetPluginsInRegistryDirectory(HKEY_CURRENT_USER,
kRegistryMozillaPlugins,
0,
&plugin_dirs);
GetPluginsInRegistryDirectory(HKEY_LOCAL_MACHINE,
kRegistryMozillaPlugins,
- KEY_WOW64_64KEY,
- &plugin_dirs);
- GetPluginsInRegistryDirectory(HKEY_LOCAL_MACHINE,
- kRegistryMozillaPlugins,
- KEY_WOW64_32KEY,
+ 0,
&plugin_dirs);
for (std::set<base::FilePath>::iterator i = plugin_dirs.begin();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698