Only scan for correct architecture plugin binaries

content/common/plugin_list_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/plugin_list.h"
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "base/file_version_info.h"
@@ skipping 366 matching lines @@
 
   for (std::set<base::FilePath>::iterator i = plugin_dirs.begin();
        i != plugin_dirs.end(); ++i) {
     plugins->push_back(*i);
   }
 }
 
 bool PluginList::ShouldLoadPluginUsingPluginList(
     const WebPluginInfo& info,
     std::vector<WebPluginInfo>* plugins) {
-  bool should_check_version = true;
-  {
-    base::AutoLock lock(lock_);
-    should_check_version =
-        std::find(extra_plugin_paths_.begin(), extra_plugin_paths_.end(),
-                  info.path) == extra_plugin_paths_.end();
+  bool wrong_architecture = false;
+
+  if (info.type == WebPluginInfo::PLUGIN_TYPE_NPAPI) {
+    base::FilePath plugin_path(info.path);
+#if defined(ARCH_CPU_X86_64)
+    // The plugin in question could be a 32 bit plugin which we cannot load.
+    if (IsValid32BitImage(base::MakeAbsoluteFilePath(plugin_path)))
+      wrong_architecture = true;
+#else
+    // The plugin in question could be a 64 bit plugin which we cannot load.
+    if (!IsValid32BitImage(base::MakeAbsoluteFilePath(plugin_path)))
+      wrong_architecture = true;
+#endif
   }
-  // Version check for plugins that are not coming from |extra_plugin_paths_|.
-  if (should_check_version) {
-    for (size_t j = 0; j < plugins->size(); ++j) {
-      base::FilePath::StringType plugin1 =
-          base::StringToLowerASCII((*plugins)[j].path.BaseName().value());
-      base::FilePath::StringType plugin2 =
-          base::StringToLowerASCII(info.path.BaseName().value());
-      if ((plugin1 == plugin2 && HaveSharedMimeType((*plugins)[j], info)) ||
-          (plugin1 == kJavaDeploy1 && plugin2 == kJavaDeploy2) ||
-          (plugin1 == kJavaDeploy2 && plugin2 == kJavaDeploy1)) {
-        if (IsNewerVersion(info.version, (*plugins)[j].version))
-          return false;  // We have loaded a plugin whose version is newer.
-        plugins->erase(plugins->begin() + j);
-        break;
+

[ananta, 2014/11/03 20:28:04]

Can we bail if wrong_architecture is true? here?

[Bernhard Bauer, 2014/11/03 22:24:22]

Alternatively:

  bool should_check_version;
  if (wrong_architecture) {
    should_check_version = false;
  } else {
    base::AutoLock lock(lock_);
    should_check_version = ...;
  }

That would at least get rid of one level of indentation.

+  if (!wrong_architecture) {
+    bool should_check_version = true;
+    {
+      base::AutoLock lock(lock_);
+      should_check_version =
+          std::find(extra_plugin_paths_.begin(), extra_plugin_paths_.end(),
+                    info.path) == extra_plugin_paths_.end();
+    }
+    // Version check for plugins that are not coming from |extra_plugin_paths_|.
+    if (should_check_version) {
+      for (size_t j = 0; j < plugins->size(); ++j) {
+        base::FilePath::StringType plugin1 =
+            base::StringToLowerASCII((*plugins)[j].path.BaseName().value());
+        base::FilePath::StringType plugin2 =
+            base::StringToLowerASCII(info.path.BaseName().value());
+        if ((plugin1 == plugin2 && HaveSharedMimeType((*plugins)[j], info)) ||
+            (plugin1 == kJavaDeploy1 && plugin2 == kJavaDeploy2) ||
+            (plugin1 == kJavaDeploy2 && plugin2 == kJavaDeploy1)) {
+          if (IsNewerVersion(info.version, (*plugins)[j].version))
+            return false;  // We have loaded a plugin whose version is newer.
+          plugins->erase(plugins->begin() + j);
+          break;
+        }
       }
     }
   }
 
   // The checks below only apply to NPAPI plugins.
   if (info.type != WebPluginInfo::PLUGIN_TYPE_NPAPI)
     return true;
 
   {
     base::AutoLock lock(lock_);
@@ skipping 49 matching lines @@
       }
     }
 
   } else if (filename == kOldWMPPlugin) {
     for (size_t j = 0; j < plugins->size(); ++j) {
       if ((*plugins)[j].path.BaseName().value() == kNewWMPPlugin)
         return false;
     }
   }
 
-  base::FilePath plugin_path(info.path);
-#if defined(ARCH_CPU_X86_64)
-  // The plugin in question could be a 32 bit plugin which we cannot load.
-  if (IsValid32BitImage(base::MakeAbsoluteFilePath(plugin_path)))
+  if (wrong_architecture)
     return false;
-#else
-  // The plugin in question could be a 64 bit plugin which we cannot load.
-  if (!IsValid32BitImage(base::MakeAbsoluteFilePath(plugin_path)))
-    return false;
-#endif
+
   return true;
 }
 
 }  // namespace content