Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 67403005: Re-enable Shim_TestAssignSrcAfterCrash. (Closed)

Created:
7 years, 1 month ago by lazyboy
Modified:
7 years, 1 month ago
Reviewers:
scheib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-enable Shim_TestAssignSrcAfterCrash. This flakiness was fixed right before it was disabled, at r233997. Last test failure at the build was at r233991. BUG=316939 Test=None, enabling test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lazyboy
Ah, got disabled right after I fixed the flakiness.
7 years, 1 month ago (2013-11-09 01:11:29 UTC) #1
scheib
lgtm
7 years, 1 month ago (2013-11-11 21:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/67403005/1
7 years, 1 month ago (2013-11-11 22:11:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/67403005/1
7 years, 1 month ago (2013-11-12 23:47:41 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 01:54:49 UTC) #5
Message was sent while issue was closed.
Change committed as 234705

Powered by Google App Engine
This is Rietveld 408576698